Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent collapsed directories order #29

Open
HipyCas opened this issue Feb 27, 2021 · 2 comments
Open

Consistent collapsed directories order #29

HipyCas opened this issue Feb 27, 2021 · 2 comments
Labels
dx Developer experience
Milestone

Comments

@HipyCas
Copy link
Contributor

HipyCas commented Feb 27, 2021

Is your feature request related to a problem? Please describe.
I started working on adding some more directories to the collapsed directories list, and I noticed that the collapsed directories array doesn't follow any consistent ordering, as the licenses did previously. Directories for different languages are not separated either grouped together.

Describe the solution you'd like
Grouping directories by language, editor/IDE, and general-purpose, and each of them sorted alphabetically. This method raises some complications in relation to grouping, as some folders could fall into many categories at the same time, which may lead to confusion regarding where to place some folders.

Describe alternatives you've considered
Another simpler option is to just order them alphabetically, which may be the best option if each of the folders is commented, in a format like <language>-<editor/IDE>, as an example. There are probably many other possibilities, and I would like to hear any that you can think of.

Additional context
⚠️ PLEASE DO NOT EDIT THE CODE YET
As mentioned before, I am currently working on adding some more directories, so implementing this change could generate some errors when trying to create a pull request further on. I would change the directories to whatever format we determine here in those editions and submit it as a pull request with the new directories.

@The-Noah The-Noah added the dx Developer experience label Feb 27, 2021
@The-Noah
Copy link
Owner

Having them grouped by language/editor looks good to me. As for some names falling under multiple categories, we could put them under a common category.

@HipyCas
Copy link
Contributor Author

HipyCas commented Feb 27, 2021

I will create a common category for directories like dist or build. I will also group each of the groups together based on their category, which means editors/IDEs together and languages together, for example. I will comment a piece of code after I worked on it, to see if everything looks fine to all as I do it.

@The-Noah The-Noah added this to the v1.0 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer experience
Projects
None yet
Development

No branches or pull requests

2 participants