Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading screen for default bevy app setup #143

Closed
TimJentzsch opened this issue Oct 15, 2024 · 1 comment · Fixed by #144
Closed

Fix loading screen for default bevy app setup #143

TimJentzsch opened this issue Oct 15, 2024 · 1 comment · Fixed by #144
Labels
A-Run Related to the bevy run command C-Bug A bug in the program

Comments

@TimJentzsch
Copy link
Collaborator

The loading screen with the default index.html we serve doesn't work for the default app setup, it isn't removed from the webpage.
It currently assumes that the canvas #bevy is used to create the app, but this needs to be configured explicitly in the Bevy app (as it was done in the bevy_quickstart template).

However, the default index.html should work with as little adjustments to the app as possible.

Therefore, we shouldn't assume a specific ID of the canvas. Instead, we can maybe observe when a new canvas element is spawned and use that event to remove the loading screen.

@TimJentzsch TimJentzsch added C-Bug A bug in the program A-Run Related to the bevy run command labels Oct 15, 2024
@BD103 BD103 linked a pull request Oct 20, 2024 that will close this issue
@BD103
Copy link
Member

BD103 commented Oct 20, 2024

Closed by #144 :)

@BD103 BD103 closed this as completed Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Run Related to the bevy run command C-Bug A bug in the program
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants