Skip to content

Add style lints for system set naming convention #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alice-i-cecile opened this issue Nov 25, 2024 · 1 comment · Fixed by #345
Closed

Add style lints for system set naming convention #183

alice-i-cecile opened this issue Nov 25, 2024 · 1 comment · Fixed by #345
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible S-Ready-for-Implementation This issue is ready for an implementation PR. Go for it!
Milestone
`bevy_lint` v0.3.0

Comments

@alice-i-cecile
Copy link
Member

I think that these should end in Set, but opinions may vary! We should have a way to automatically and consistently enforce this. Related to #47.

Raised by @Jondolf on Discord:

Our system set naming is very inconsistent, there's Foo, FooSet, FooSystem, FooSteps
@alice-i-cecile alice-i-cecile added A-Linter Related to the linter and custom lints C-Feature Make something new possible labels Nov 25, 2024
@benfrankel
Copy link

benfrankel commented Nov 25, 2024 •
edited
Loading

Also other naming conventions. See bevyengine/bevy#14274 for a summary of naming conventions within Bevy itself at the time the issue was created. For example, components not ending with Component is a convention that could have a lint. EDIT: I see that specific case is #47 :)

@BD103 BD103 added this to the `bevy_lint` 0.2.0 milestone Nov 25, 2024
@BD103 BD103 mentioned this issue Nov 25, 2024
Closed
@DaAlbrecht DaAlbrecht added the S-Ready-for-Implementation This issue is ready for an implementation PR. Go for it! label Mar 10, 2025
@DaAlbrecht DaAlbrecht mentioned this issue Apr 6, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in `bevy_lint` Lints Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Linter Related to the linter and custom lints C-Feature Make something new possible S-Ready-for-Implementation This issue is ready for an implementation PR. Go for it!
Projects
`bevy_lint` Lints
Status: Done
Milestone
`bevy_lint` v0.3.0
Development

Successfully merging a pull request may close this issue.

Add lint: unconventional_naming TheBevyFlock/bevy_cli
4 participants
@alice-i-cecile @benfrankel @DaAlbrecht @BD103