From c403e76ec5cf97ec67c6cee7456ae21d71bf025f Mon Sep 17 00:00:00 2001 From: Raju Prasai Date: Sun, 31 Mar 2024 09:55:33 +0545 Subject: [PATCH] chore: enhancements --- README.md | 11 ++++++----- src/NepDate/Abilities/Comparable.cs | 2 -- src/NepDate/Abilities/Equatable.cs | 2 -- src/NepDate/Abilities/Formattable.cs | 1 - src/NepDate/Abilities/Operatable.cs | 2 -- src/NepDate/BulkConvert.cs | 6 +++--- src/NepDate/Core/Dictionaries/Unicodes.cs | 4 +--- src/NepDate/Core/Enums/DateFormats.cs | 2 +- src/NepDate/Core/Enums/FiscalYearQuarters.cs | 2 +- src/NepDate/Core/Enums/NepaliMonths.cs | 2 +- src/NepDate/Core/Enums/Separators.cs | 2 +- src/NepDate/FiscalYear.cs | 3 +-- src/NepDate/Properties.cs | 1 - tests/NepDate.Tests/NepaliDateTests.cs | 3 +-- 14 files changed, 16 insertions(+), 27 deletions(-) diff --git a/README.md b/README.md index f22083a..2a8be8e 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ ### Install NepDate with the package manager console ```bash -NuGet\Install-Package NepDate +Install-Package NepDate ``` ### Install NepDate with the .NET CLI @@ -24,7 +24,7 @@ dotnet add package NepDate ## Features -NepDate is a `struct` based on `.NET Standard 2.0` that closely resembles the `DateOnly` `struct` in `.NET`. It stands out due to its `easy integration`, `super-fast` and `memory-efficient` conversions, and built in `powerful features` related to Nepali date functionality. +NepDate is a super-fast and memory-efficient `struct` based on `.NET Standard 2.0` that closely resembles the `DateOnly` `struct` in `.NET` with built in powerful features related to Nepali date functionality. ### Initialization @@ -154,6 +154,7 @@ nepDate.FiscalYearQuarterEndDate(); // 2081/06/30 nepDate.FiscalYearQuarterStartAndEndDate(); // (2081/04/01, 2081/06/30) // Also can achieve the same details through parameters +// Here, We take the first year as Fiscal Year. Eg: 2080 means Fy 2080/2081 NepaliDate.GetFiscalYearStartDate(2080); // 2080/04/01 NepaliDate.GetFiscalYearEndDate(2080); // 2081/03/31 NepaliDate.GetFiscalYearStartAndEndDate(2080); // (2080/04/01, 2081/03/31) @@ -169,13 +170,13 @@ var engDates = new List(); var nepDatesAsString = new List(); // Converts a collection of English dates to Nepali dates -var newNepDates = NepaliDate.BulkConvert.ToNepaliDate(engDates); +var newNepDates = NepaliDate.BulkConvert.ToNepaliDates(engDates); // Converts a collection of Nepali date instances to English dates -var newEngDates = NepaliDate.BulkConvert.ToEnglishDate(newNepDates); +var newEngDates = NepaliDate.BulkConvert.ToEnglishDates(newNepDates); // Converts a collection of Nepali dates represented as strings to English dates -var newEngDates = NepaliDate.BulkConvert.ToEnglishDate(nepDatesAsString); +var newEngDates = NepaliDate.BulkConvert.ToEnglishDates(nepDatesAsString); ``` ### Additional Functions diff --git a/src/NepDate/Abilities/Comparable.cs b/src/NepDate/Abilities/Comparable.cs index 5badcce..258a208 100644 --- a/src/NepDate/Abilities/Comparable.cs +++ b/src/NepDate/Abilities/Comparable.cs @@ -1,6 +1,4 @@ using System; -using System.Collections.Generic; -using System.Text; namespace NepDate { diff --git a/src/NepDate/Abilities/Equatable.cs b/src/NepDate/Abilities/Equatable.cs index cb52272..0064089 100644 --- a/src/NepDate/Abilities/Equatable.cs +++ b/src/NepDate/Abilities/Equatable.cs @@ -1,6 +1,4 @@ using System; -using System.Collections.Generic; -using System.Text; namespace NepDate { diff --git a/src/NepDate/Abilities/Formattable.cs b/src/NepDate/Abilities/Formattable.cs index b035398..67f8cd0 100644 --- a/src/NepDate/Abilities/Formattable.cs +++ b/src/NepDate/Abilities/Formattable.cs @@ -1,5 +1,4 @@ using NepDate.Core.Dictionaries; -using NepDate.Core.Enums; using NepDate.Exceptions; using System; using System.Text; diff --git a/src/NepDate/Abilities/Operatable.cs b/src/NepDate/Abilities/Operatable.cs index b295cd5..0e7f3da 100644 --- a/src/NepDate/Abilities/Operatable.cs +++ b/src/NepDate/Abilities/Operatable.cs @@ -1,6 +1,4 @@ using System; -using System.Collections.Generic; -using System.Text; namespace NepDate { diff --git a/src/NepDate/BulkConvert.cs b/src/NepDate/BulkConvert.cs index 9a5baea..58f16ff 100644 --- a/src/NepDate/BulkConvert.cs +++ b/src/NepDate/BulkConvert.cs @@ -16,7 +16,7 @@ public class BulkConvert /// /// The collection of English dates to convert. /// An IEnumerable of NepaliDate corresponding to the input English dates. - public static IEnumerable ToNepaliDate(IEnumerable engDates) + public static IEnumerable ToNepaliDates(IEnumerable engDates) { return engDates.Select(item => new NepaliDate(item)); } @@ -27,7 +27,7 @@ public static IEnumerable ToNepaliDate(IEnumerable engDate /// /// The collection of Nepali dates (as strings) to convert. /// An IEnumerable of DateTime representing the English dates corresponding to the input Nepali dates. - public static IEnumerable ToEnglishDate(IEnumerable nepDates) + public static IEnumerable ToEnglishDates(IEnumerable nepDates) { return nepDates.Select(item => Parse(item).EnglishDate); } @@ -38,7 +38,7 @@ public static IEnumerable ToEnglishDate(IEnumerable nepDates) /// /// The collection of Nepali dates to convert. /// An IEnumerable of DateTime representing the English dates corresponding to the input Nepali dates. - public static IEnumerable ToEnglishDate(IEnumerable nepDates) + public static IEnumerable ToEnglishDates(IEnumerable nepDates) { return nepDates.Select(item => item.EnglishDate); } diff --git a/src/NepDate/Core/Dictionaries/Unicodes.cs b/src/NepDate/Core/Dictionaries/Unicodes.cs index a634f61..f20a51b 100644 --- a/src/NepDate/Core/Dictionaries/Unicodes.cs +++ b/src/NepDate/Core/Dictionaries/Unicodes.cs @@ -1,7 +1,5 @@ -using NepDate.Core.Enums; -using System; +using System; using System.Collections.Generic; -using System.Text; namespace NepDate.Core.Dictionaries { diff --git a/src/NepDate/Core/Enums/DateFormats.cs b/src/NepDate/Core/Enums/DateFormats.cs index ca9fbee..e7cf9ae 100644 --- a/src/NepDate/Core/Enums/DateFormats.cs +++ b/src/NepDate/Core/Enums/DateFormats.cs @@ -1,4 +1,4 @@ -namespace NepDate.Core.Enums +namespace NepDate { public enum DateFormats { diff --git a/src/NepDate/Core/Enums/FiscalYearQuarters.cs b/src/NepDate/Core/Enums/FiscalYearQuarters.cs index 70a6050..d99a502 100644 --- a/src/NepDate/Core/Enums/FiscalYearQuarters.cs +++ b/src/NepDate/Core/Enums/FiscalYearQuarters.cs @@ -1,4 +1,4 @@ -namespace NepDate.Core.Enums +namespace NepDate { public enum FiscalYearQuarters { diff --git a/src/NepDate/Core/Enums/NepaliMonths.cs b/src/NepDate/Core/Enums/NepaliMonths.cs index 118800e..d5333a3 100644 --- a/src/NepDate/Core/Enums/NepaliMonths.cs +++ b/src/NepDate/Core/Enums/NepaliMonths.cs @@ -1,4 +1,4 @@ -namespace NepDate.Core.Enums +namespace NepDate { public enum NepaliMonths { diff --git a/src/NepDate/Core/Enums/Separators.cs b/src/NepDate/Core/Enums/Separators.cs index 738a920..3fe0128 100644 --- a/src/NepDate/Core/Enums/Separators.cs +++ b/src/NepDate/Core/Enums/Separators.cs @@ -1,6 +1,6 @@ using System.ComponentModel; -namespace NepDate.Core.Enums +namespace NepDate { public enum Separators { diff --git a/src/NepDate/FiscalYear.cs b/src/NepDate/FiscalYear.cs index 7c2581a..f8e375d 100644 --- a/src/NepDate/FiscalYear.cs +++ b/src/NepDate/FiscalYear.cs @@ -1,5 +1,4 @@ -using NepDate.Core.Enums; -using NepDate.Exceptions; +using NepDate.Exceptions; namespace NepDate { diff --git a/src/NepDate/Properties.cs b/src/NepDate/Properties.cs index 496467a..4ef1b92 100644 --- a/src/NepDate/Properties.cs +++ b/src/NepDate/Properties.cs @@ -1,5 +1,4 @@ using NepDate.Core.Dictionaries; -using NepDate.Core.Enums; using NepDate.Extensions; using System; diff --git a/tests/NepDate.Tests/NepaliDateTests.cs b/tests/NepDate.Tests/NepaliDateTests.cs index 9afcb4f..4c166dd 100644 --- a/tests/NepDate.Tests/NepaliDateTests.cs +++ b/tests/NepDate.Tests/NepaliDateTests.cs @@ -1,5 +1,4 @@ -using NepDate.Core.Enums; -using NepDate.Exceptions; +using NepDate.Exceptions; namespace NepDate.Tests;