Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge features from optiflows-cookbooks/vsftpd #8

Open
guilhem opened this issue Sep 20, 2014 · 10 comments
Open

Merge features from optiflows-cookbooks/vsftpd #8

guilhem opened this issue Sep 20, 2014 · 10 comments

Comments

@guilhem
Copy link

guilhem commented Sep 20, 2014

Hi @TheSerapher

I'm happy to see a updated cookbook for vsftpd.

Months ago I forked https://github.com/cwjohnston/chef-vsftpd to https://github.com/optiflows-cookbooks/vsftpd and updates some parts.

It would be cool to merge some features like LWRP for virtual users etc.

@TheSerapher
Copy link
Owner

I think that's a great idea. I can look into it or you can even PR the changes. I will merge into next and adjust if needed.

@TheSerapher
Copy link
Owner

I just checked your cookbook @guilhem and I like it. A lot of additions that I never got around to add (like CB included user management, very nice). Mine was pretty basic and did what I needed back then, but it sure could need some love to make it usable for others too.

Maybe your version should be used instead? That is if you are able to maintain it.

@guilhem
Copy link
Author

guilhem commented Sep 22, 2014

@TheSerapher My version is more advanced in some points yes. but need some improvements.
If you want, I can make it even better (some syntax to clean up) then push it on: http://github.com/redguide (I push there cookbooks to be maintain without any personal/enterprise problem/ego) then add you as contributor for any further update.

@TheSerapher
Copy link
Owner

That sounds great. Maybe we can even get Supermarket permissions placed on our project instead so we can start uploading it for others to use.

@guilhem
Copy link
Author

guilhem commented Sep 23, 2014

hi @TheSerapher
I didn't really understand you last message ^^
But in the meantime I've updated my cookbook with some cool features like auto generated vsftpd.conf \o/ (and correct all foodcritic / rubocop issues 👼 ).

@TheSerapher
Copy link
Owner

Supermarket.getchef.com

It's used by tools like knife and berkshelf to auto discover a cookbook. Currently the vsftp cookbook there is probably and older outdated version.

I shall take a look at your cookbook. If that works well we can close my repo and I point them towards yours.

@damacus
Copy link
Contributor

damacus commented Oct 28, 2014

@TheSerapher I believe the only way currently to change ownership of the vsftp cookbook on supermarket.getchef.com is to reach out to the current owner and ask him/her to change ownership.

@TheSerapher
Copy link
Owner

Thanks for the info, that will probably make it rather complicated since I am not sure if that user is reachable or active at all ..

@damacus
Copy link
Contributor

damacus commented Oct 28, 2014

I shall try and get you some details, apparently he is very approachable, so I'm sure we can work something out :)

@damacus
Copy link
Contributor

damacus commented Oct 28, 2014

Looks like there are some contact details on his github profile: https://github.com/rberger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants