Implement badge voting/ranking system to allow community members to v…#124
Merged
joelamouche merged 6 commits intoTheSoftwareDevGuild:mainfrom Oct 30, 2025
Merged
Conversation
…ote on badge relevancy
tusharshah21
requested review from
Teddy1792,
joelamouche and
oscarwroche
as code owners
joelamouche
requested changes
Oct 28, 2025
Contributor
joelamouche
left a comment
joelamouche
left a comment
There was a problem hiding this comment.
Looks pretty good overall!
Please add a simple deployment script (uses hardcoded badge registry address) and add deployment of this contract to the full deployment script.
Also pls update readme
joelamouche
reviewed
Oct 29, 2025
joelamouche
reviewed
Oct 29, 2025
joelamouche
reviewed
Oct 29, 2025
joelamouche
requested changes
Oct 29, 2025
Collaborator
Author
|
Hey @joelamouche thanks for the pointing details, hoping I have covered it now! Let me know if anything is wrong still! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement badge voting/ranking system to allow community members to vote on badge relevancy, helping to filter spam badges and promote the most relevant ones.
Changes
TheGuildBadgeRankingTheGuildBadgeRegistryto enable voting on badgesBadgeUpvotedevent for off-chain indexingTechnical Details
TheGuildBadgeRegistryas constructor argument for badge validationbytes32badge names for consistent data structureRelated Issue
Closes #122