From 18a657a1fcca2b3e47ccd8eba37a115f29f852f2 Mon Sep 17 00:00:00 2001
From: Laz <lazdisco@gmail.com>
Date: Mon, 10 Jul 2023 15:20:59 +0100
Subject: [PATCH] cicd: set sonar scan to not specify the PR key if no number
 is provided

---
 .github/workflows/sonar-scan.yml | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/sonar-scan.yml b/.github/workflows/sonar-scan.yml
index 3a1dc7b38..dae384993 100644
--- a/.github/workflows/sonar-scan.yml
+++ b/.github/workflows/sonar-scan.yml
@@ -49,9 +49,11 @@ jobs:
       - name: 'Unzip Artifacts'
         run: |
           Expand-Archive -Force sonar-build.zip ${{ env.BUILD_WRAPPER_OUT_DIR }}
-          Expand-Archive -Force pr-number.zip .
-          $number = Get-Content -Path pr-number.txt
-          echo "PR_NUMBER=$number" >> $env:GITHUB_ENV
+          if (Test-Path -Path pr-number.zip) {
+            Expand-Archive -Force pr-number.zip .
+            $number = Get-Content -Path pr-number.txt
+            echo "PR_NUMBER=$number" >> $env:GITHUB_ENV
+          }
       - name: Set up JDK 11
         uses: actions/setup-java@v1
         with:
@@ -72,4 +74,5 @@ jobs:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         run: |
-          sonar-scanner --define sonar.pullrequest.key="${{ env.PR_NUMBER }}" --define sonar.host.url="${{ env.SONAR_SERVER_URL }}" --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}"
+          if ($null -ne $env:PR_NUMBER) { sonar-scanner --define sonar.pullrequest.key="${{ env.PR_NUMBER }}" --define sonar.host.url="${{ env.SONAR_SERVER_URL }}" --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" }
+          else { sonar-scanner --define sonar.host.url="${{ env.SONAR_SERVER_URL }}" --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" }