refactor(network): Replace implicit conversion from NULL to AsciiString in IPEnumeration::getMachineName #1934
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
added
the
Refactor
xezon
reviewed
Dec 1, 2025
xezon
approved these changes
Dec 1, 2025
xezon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit conversion from
NULLcan be ambiguous; it can be either a pointer or an integer.It's also potentially less optimal - depending on whether the compiler can optimize this away - because the current constructor needs to check whether the input is a
nullptr.We could do
return "";but that's also potentially less optimal for the same reason.