Skip to content

Conversation

@bobtista
Copy link

@bobtista bobtista commented Dec 1, 2025

  • Used clang-tidy

@bobtista bobtista marked this pull request as draft December 1, 2025 21:45
@Caball009
Copy link

Caball009 commented Dec 1, 2025

Are we sure that VC6 treats inline the same way as modern compilers do? I think we've seen in the past that different function inlining can cause mismatches for seemingly obscure reasons.

I'd recommend running this change against a large number of replays.

@bobtista bobtista force-pushed the bobtista/build/clang-tidy-redundant-inline branch from 0629427 to 92878b7 Compare December 1, 2025 22:49
@bobtista
Copy link
Author

bobtista commented Dec 1, 2025

VC6 treats inline the same way as modern compilers do

Section 7.1.2: "A function defined within a class definition is an inline function."
C++98 Standard (ISO/IEC 14882:1998)

This means member functions defined inside class bodies are implicitly inline in C++98, regardless of the inline keyword. VC6 claims C++98 support, so it should follow this. How many replays does our CI check with?

@xezon
Copy link

xezon commented Dec 2, 2025

If they were not implict inline then it would compile error, because of duplicate symbol definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants