Merge pull request #7321 from TheThingsNetwork/fix/top-devices-leak

Fix device ID check for top devices in the app overview

Author: kschiffer

CHANGELOG.md

@@ -19,6 +19,8 @@ For details about compatibility between different releases, see the **Commitment
 
 ### Fixed
 
+- Potential leak of end devices of other (owned) applications in the top end devices panel in the application overview of the Console.
+
 ### Security
 
 ## [3.32.1] - unreleased

pkg/webui/console/containers/top-entities-dashboard-panel/top-devices/index.js

@@ -31,7 +31,10 @@ import { selectEndDeviceTopEntities } from '@console/store/selectors/top-entitie
 import EntitiesList from '../list'
 
 const TopDevicesList = ({ appId }) => {
-  const topEntityFilter = useMemo(() => (appId ? e => e.id.startsWith(appId) : undefined), [appId])
+  const topEntityFilter = useMemo(
+    () => (appId ? e => e.id.split('/')[0] === appId : undefined),
+    [appId],
+  )
   const items = useSelector(state => selectEndDeviceTopEntities(state, topEntityFilter))
 
   const headers = [