Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Cast School color on channels-- #2

Open
wwbrandon opened this issue Oct 22, 2024 · 16 comments
Open

Request for Cast School color on channels-- #2

wwbrandon opened this issue Oct 22, 2024 · 16 comments

Comments

@wwbrandon
Copy link

wwbrandon commented Oct 22, 2024

Love your addon and tying to switch from Quartz--

Would you be able to add school coloring for Channeled spelled? Penance vs. Dark Reprimand would be nice to see.

And Power Word: Radiance isn't coloring by school either for some reason.

@TheTrueIndolent
Copy link
Owner

Hello and thank you for the comment and your kind words!
Althought the add on takes the school from the combat log, I will investigate it!
I will work more on the school colors on the next updates!

@wwbrandon
Copy link
Author

wwbrandon commented Oct 23, 2024

Thanks for looking into this, I'm not sure why PW: Radiance wouldn't be included... not colored for Holy.
image
image
(edit: oh dang I think the school is Radiant, not Holy nvm :D )


But as a Disc Priest I love the roleplay seeing the Holy vs. Shadow casts, would love to see this distinguished between the channel of Penance and Dark Reprimand. Holy vs. Shadow.
image
image


Also noticing when I spam spells sometimes it doesn't fetch the school information- and defaults to standard color??
https://github.com/user-attachments/assets/740dd9ce-e8f6-4fce-a476-ecec90e1695b

Already made the switch over, thanks for the addon! Love it!

@TheTrueIndolent
Copy link
Owner

Hello again and thank you for the infos! I search what was wrong with Discipline Priest and I found that blizzard made a mess with the IDs of the spells! Anyway the version 1.57 should fix the issue with the colors, now I'm looking for the issue with the ticks!

@wwbrandon
Copy link
Author

wwbrandon commented Oct 26, 2024

Thanks for fixing Penance/Dark Reprimand, they are working great now! Con confirm tho the school is still not fetching properly sometimes when I spam spells-- check this video out to see
https://github.com/user-attachments/assets/740dd9ce-e8f6-4fce-a476-ecec90e1695b

Also, look how this WA incorporates showing GCD, it's beautiful! I could see your addon doing it better with school coloring :D
https://wago.io/-iMgHlW6n

Are there any ways I can support your work? Thanks for taking the reports


image
image

Has a green-ish element to the channel still and a slight different color from the casts?

image
image

@TheTrueIndolent
Copy link
Owner

Hello there!
I've made some more changes to the colors; I hope they look much prettier now!

@wwbrandon
Copy link
Author

Thanks man, love it! Did you see how sometimes the color doesn't load when spamming spells?

@Beverodisc
Copy link

Hi! Disc priest speaking. I have the same issue. When i spam a certain ability (void blast) its just changes in color. And sometimes even to the original green color. So maybe thats something you could possibly look into?

@TheTrueIndolent
Copy link
Owner

Hello there and thank you for your constant feedback!
I made more changes to the colors; I hope it will fix the issue!

@wwbrandon
Copy link
Author

Hello there and thank you for your constant feedback! I made more changes to the colors; I hope it will fix the issue!

thank you for your attention on this, I'm unable to replicate the bug- so I think it's fixed!

@wwbrandon
Copy link
Author

Maybe add option to hide Target's Cast's Icon?

@TheTrueIndolent
Copy link
Owner

I will add it in the future update! :)

@wwbrandon
Copy link
Author

wwbrandon commented Nov 20, 2024

Hoping to see the target spell icon hide feature soon?

@TheTrueIndolent
Copy link
Owner

Right now, I am trying to make the boss's cast bar more stable! But I will add it soon!

@wwbrandon
Copy link
Author

awesome thanks man! <3

@TheTrueIndolent
Copy link
Owner

Today's update adds the option to hide/show the icon for the target and focus cast bars!

@wwbrandon
Copy link
Author

Thanks a ton!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants