Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Using universal links with preferEphemeral true does not work #123

Open
2 tasks done
alexboulay opened this issue Aug 28, 2024 · 3 comments
Open
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@alexboulay
Copy link

alexboulay commented Aug 28, 2024

Description

First, thank you for this project, it helps us a lot.

I have noticed that the redirect (closing of the auth pop-up) does not work when using universal links on iOS when preferEphemeral is set to false. It does however work with true.

Not sure if this is related to ASWebAuthenticationSession or this Flutter package.

In any case, I would appreciate if some light can be shed on why this happens.

Thank you.

Minimal Reproduction

Steps to reproduce the behaviour:

Set up Universal Links
Use FlutterWebAuth2 with preferEphemeral set to false
Notice you wont get redirected once the auth flow is completed.

Exception or Error

No Exception.

Expected Behaviour

Should redirect regardless of preferEphemeral is true or false

Screenshots

No response

Additional context

No response

Device

iPhone

OS

17.4

Browser

NA

Flutter version

3.24.0

flutter_web_auth_2 version

3.1.2

Checklist

  • I have read and followed the entire troubleshooting guide and it has not provided the solution I need.
  • I have provided all the information I can.
@alexboulay alexboulay added the bug Something isn't working label Aug 28, 2024
@ThexXTURBOXx
Copy link
Owner

Just supplying version "latest" or "stable" does not help. Please specify exactly which version. Also try out the latest preview (4.x)

@alexboulay
Copy link
Author

I updated my question to specify the versions.

I will try out 4.x soon.

In the meantime, I just want to add that I made my post immediately after trying out Microsoft OAuth flow.

I then tried Google but the redirect inside the app did not work, regardless of using preferEphemeral. The window did not close and it only redirected to my actual domain within the window. Then, I tried to configure Google OAuth with a custom scheme and it worked fine. I think I officially hate implementing OAuth flows and to think I am only doing this high-level makes me even more grateful for your work.

@ThexXTURBOXx
Copy link
Owner

You're welcome :)
4.x actually supports the new authentication functions from newer versions of the SDK - maybe that fixes your problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants