Skip to content

Conversation

@zerob13
Copy link
Collaborator

@zerob13 zerob13 commented Dec 4, 2025

  • add workspaceview for acp

feat: use iframe to replace innerHTML
* fix: #1153 only success tool_call block in message with response

* fix: selectedVariantsMap cache
* feat: add init docs

* feat(acp): implement fs and terminal capabilities for full ACP support

- Add AcpCapabilities module for client capability declaration
- Implement AcpFsHandler for read_text_file and write_text_file
  with workspace boundary validation
- Implement AcpTerminalManager for PTY-based terminal execution
  with output buffering and lifecycle management
- Update acpProcessManager to wire fs/terminal handlers and
  advertise capabilities during initialization
- Register session workdirs for fs operation security checks

* feat(acp): add structured plan and mode update handling

- Improve plan updates with structured PlanEntry type
- Add status icons and formatted plan display
- Handle current_mode_update notifications
- Store plan entries and mode changes in MappedContent
- Add extra metadata to reasoning blocks for UI access

* test(acp): add unit tests for ACP capabilities, fs handler, and content mapper

- Add tests for buildClientCapabilities options
- Add comprehensive tests for AcpFsHandler:
  - Path validation and workspace boundary checks
  - Read with line offset and limit parameters
  - Write with directory creation
- Add tests for plan and mode update handling in content mapper:
  - Structured plan entries with status icons
  - Mode change notifications

* feat: add support acp plan

* fix: i18n

* fix: add i18n

* feat: add mode switcher

* chore: mode only show in agent conv

* fix: message tool parser and mode switch

* feat: mask env and inject env on init

* fix: code reviewer issues
* feat: add workspaceview for acp agent

* feat: support workspace dirs

* fix: workspace file refresh

* fix: tool call status

* fix: review refactor
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

* fix: keep last file list

* feat(acp-workspace): add file context actions

* fix(acp-workspace): move path helpers to preload

* fix(preload): allow empty relative path

* fix(preload): escape quotes when formatting paths
@zerob13 zerob13 merged commit 6b10d2d into main Dec 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants