Crash on WinXP and Win7, but works on Win 8.1

[hali9]

Just crash when call ReadFile or WriteFile.
It also works on Win 8.

[ThomHPL]

ReadFile and WriteFile are standard IO functions to access the COM port.
Maybe the issue comes from the serial to usb adapter you are using? The drivers might not work for older Windows.

[hali9]

I don't think that it is problem with driver.
I flashed firmware 10ch_Mavlink_MOD_i6_Programmer_V1_.exe from https://github.com/benb0jangles/FlySky-i6-Mod- on this same computer with this same wire and driver and it works.

I thought maybe I have something wrong installed, but @MKMELab also report problem:
https://www.rcgroups.com/forums/showthread.php?2486545-FlySky-FS-i6-8-channels-firmware-patch!/page120

I also try test it using virtual com port and two terminal and 10ch_Mavlink_MOD_i6_Programmer_V1_.exe works and BaseI6_updater crash (on the receive terminal I get one byte before crash).

This may be due to the version of the library used during compilation ?

[ThomHPL]

Can you give me the error you are receiving when the crash occurs? (if you are getting any)
I must say it's been a while since I've released this software, I've got to refresh my memory about it.

[hali9]

There is what I get, error is inside WriteFile:



ecdc_appcompat.txt

<?xml version="1.0" encoding="UTF-16"?>
<DATABASE>
<EXE NAME="BaseI6_updater.exe" FILTER="GRABMI_FILTER_PRIVACY">
    <MATCHING_FILE NAME="BaseI6_updater.exe" SIZE="83881" CHECKSUM="0xE45C09E8" MODULE_TYPE="WIN32" PE_CHECKSUM="0x18CEE" LINKER_VERSION="0x10000" LINK_DATE="08/15/2016 17:09:55" UPTO_LINK_DATE="08/15/2016 17:09:55" />
</EXE>
<EXE NAME="kernel32.dll" FILTER="GRABMI_FILTER_THISFILEONLY">
    <MATCHING_FILE NAME="kernel32.dll" SIZE="1018368" CHECKSUM="0xDFB784AB" BIN_FILE_VERSION="5.1.2600.5512" BIN_PRODUCT_VERSION="5.1.2600.5512" PRODUCT_VERSION="5.1.2600.5512" FILE_DESCRIPTION="Biblioteka DLL klienta Windows NT BASE API" COMPANY_NAME="Microsoft Corporation" PRODUCT_NAME="System operacyjny Microsoft® Windows®" FILE_VERSION="5.1.2600.5512 (xpsp.080413-2111)" ORIGINAL_FILENAME="kernel32" INTERNAL_NAME="kernel32" LEGAL_COPYRIGHT="© Microsoft Corporation. Wszelkie prawa zastrzeżone." VERFILEDATEHI="0x0" VERFILEDATELO="0x0" VERFILEOS="0x40004" VERFILETYPE="0x2" MODULE_TYPE="WIN32" PE_CHECKSUM="0xFD4C6" LINKER_VERSION="0x50001" UPTO_BIN_FILE_VERSION="5.1.2600.5512" UPTO_BIN_PRODUCT_VERSION="5.1.2600.5512" LINK_DATE="04/14/2008 17:19:14" UPTO_LINK_DATE="04/14/2008 17:19:14" VER_LANGUAGE="Polski [0x415]" />
</EXE>
<EXE NAME="kernel32.dll" FILTER="GRABMI_FILTER_THISFILEONLY">
    <MATCHING_FILE NAME="kernel32.dll" SIZE="1018368" CHECKSUM="0xDFB784AB" BIN_FILE_VERSION="5.1.2600.5512" BIN_PRODUCT_VERSION="5.1.2600.5512" PRODUCT_VERSION="5.1.2600.5512" FILE_DESCRIPTION="Biblioteka DLL klienta Windows NT BASE API" COMPANY_NAME="Microsoft Corporation" PRODUCT_NAME="System operacyjny Microsoft® Windows®" FILE_VERSION="5.1.2600.5512 (xpsp.080413-2111)" ORIGINAL_FILENAME="kernel32" INTERNAL_NAME="kernel32" LEGAL_COPYRIGHT="© Microsoft Corporation. Wszelkie prawa zastrzeżone." VERFILEDATEHI="0x0" VERFILEDATELO="0x0" VERFILEOS="0x40004" VERFILETYPE="0x2" MODULE_TYPE="WIN32" PE_CHECKSUM="0xFD4C6" LINKER_VERSION="0x50001" UPTO_BIN_FILE_VERSION="5.1.2600.5512" UPTO_BIN_PRODUCT_VERSION="5.1.2600.5512" LINK_DATE="04/14/2008 17:19:14" UPTO_LINK_DATE="04/14/2008 17:19:14" VER_LANGUAGE="Polski [0x415]" />
</EXE>
</DATABASE>

[mhrnko]

I hope this helps

File serial.c

121,125c121,125
< PDWORD nBytesWritten=0;
< if(!WriteFile(*hdlr, &byte, 1, nBytesWritten, NULL))
< {
< return -1; // error
< }

  DWORD nBytesWritten=0;
  if(!WriteFile(*hdlr, &byte, 1, &nBytesWritten, NULL))
  {
          return -1;      // error
  }

145,148c145,148
< PDWORD nBytesWritten=0;
< if(!WriteFile(*hdlr, array, size, nBytesWritten, NULL)) {
< return -1; // error
< }

  DWORD nBytesWritten=0;
  if(!WriteFile(*hdlr, array, size, &nBytesWritten, NULL)) {
          return -1;      // error
  }

155,156c155,156
< PDWORD nBytesRead=0;
< if(!ReadFile(*hdlr, byte, 1, nBytesRead, NULL)) {

  DWORD nBytesRead=0;
  if(!ReadFile(*hdlr, byte, 1, &nBytesRead, NULL)) {