Skip to content

chore: port flight-crew-scheduling quickstart example from Java to Python #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: port flight-crew-scheduling quickstart example from Java to Python #703

merged 1 commit into from
Jan 30, 2025

Conversation

PatrickDiallo23
Copy link

@PatrickDiallo23 PatrickDiallo23 commented Jan 27, 2025 •
edited by Christopher-Chianelli
Loading

Description of the change

Port the flight-crew-scheduling quickstart example from Java to Python while keeping the same functionality.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

Christopher-Chianelli
Christopher-Chianelli requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@Christopher-Chianelli Christopher-Chianelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would refactor some of the logic to simplify it and make it easier to read.

@PatrickDiallo23 PatrickDiallo23 force-pushed the flight-crew-scheduling-python-example branch from eddccad to 2b68762 Compare January 30, 2025 19:40
@Christopher-Chianelli Christopher-Chianelli merged commit ac19192 into TimefoldAI:development Jan 30, 2025
7 checks passed
@Christopher-Chianelli
Copy link
Contributor

Thanks for your contribution @PatrickDiallo23!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christopher-Chianelli Christopher-Chianelli Christopher-Chianelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatrickDiallo23 @Christopher-Chianelli