Small login issue

[Luke53]

Hi.
Looks like a small logic error on line 87 of Login.py

87: exist = (yield client.db_penguinExists('username', user)) if user != '$fire' and FIREBASE_INIT else True

This throws error from DB.py as it stills try to login even with an invalid penguin name.
If username !='$fire' and FIREBASE_INIT then is firebase is not initialised we will get 0 on this condition and set exist to true.

Can easily be fixed with:

exist = (yield client.db_penguinExists('username', user)) if (user != '$fire' and FIREBASE_INIT == 0) else True

[valid22]

Thanks for pointing this out! Kudos to you. I'll bring out a fix and update you soon.

[valid22]

Ref, bdac712

Hope that helps.

[Luke53]

That fixes is. Also quick question did you ever have a glitch with the skate-park lines with testing? I made a server side fix when i was messing around with kitsune but I feel like it is my client.
Also great work this CPPS source looks really great.

[valid22]

I did experience it during early stages of production, never experienced it then after

[Luke53]

Must be something with my client then because it still occurs with different server sources. Thanks anyway.

[valid22]

It could still potentially be a server issue idk, I'll check and confirm later, mainly because I was able to fix it before by tweaking server. I doubt if other sources knew that thing was supposed to be implemented on server.
Anyway, marking this issue as fixed.

[Luke53]

@valid22 Sorry to bug you again but is there a reason why EPF features were removed? Was it broken?

[valid22]

Not broken, I don't see the point of having it :male_shrug:
It was meaningful when it had missions, but CP itself abandoned it for years. Only reason to have it was because of its teleportation, but that can be achieved via !jr command.

Still it's just disabled, you can tweak some comments to bring it back alive

[Luke53]

Okay thanks