How to correct to read chunk packet?

[patyhank]

Current:

                        var chunkX, chunkZ packet.Int
			var heightmaps nbt.RawMessage
			var size pk.VarInt
			r := bytes.NewBuffer(p.Data)
			pk.Tuple{&chunkX, &chunkZ, pk.NBT(heightmaps), &size}.ReadFrom(r)
			sectionLens := world.Height / 16
			sections := map[int]level.Section{}
			for i := 0; i < sectionLens; i++ {
				var section level.Section
				section.ReadFrom(r)
				sections[i] = section
			}

Error:

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x8 pc=0x800683]

goroutine 1 [running]:
github.com/Tnze/go-mc/level.(*PaletteContainer).ReadFrom(0x0, {0x975ba0, 0xc0008c5c50})
github.com/Tnze/go-mc/level.(*Section).ReadFrom(0xc000a99f20, {0x975ba0, 0xc0008c5c50})

[Tnze]

I implemented pk.FieldDecoder for level.Chunk yesterday. Just not commit yet

[Tnze]

If any bug exist, help fix it plz

[patyhank]

temporary workaround:
palette.go:L135

n += nn
p.data = NewBitStorage(p.config.bits(int(bits)),p.data.Len(),p.data.Raw()) // <-- add
if err != nil {
	return n, err
}

[Tnze]

Do this patch fix it?

Index: level/palette.go
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/level/palette.go b/level/palette.go
--- a/level/palette.go	(revision c3a997f1c44f528342f72020e47d22edb77c1b7d)
+++ b/level/palette.go	(date 1647165412596)
@@ -123,6 +123,7 @@
 	if err != nil {
 		return
 	}
+	p.bits = int(bits)
 	p.palette = p.config.create(int(bits))
 
 	nn, err := p.palette.ReadFrom(r)

[patyhank]

It's seem no.

[patyhank]

I found that many values of BitStorage are empty when initialized with NewStatesPaletteContainer().
Maybe reinitialize the p.data?

[Tnze]

pk.NBT(&heightmaps)