Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Align /discord-bot codebase to super-linter #47

Open
Tracked by #45
cyri113 opened this issue Jul 6, 2023 · 0 comments
Open
Tracked by #45

CI: Align /discord-bot codebase to super-linter #47

cyri113 opened this issue Jul 6, 2023 · 0 comments
Assignees
Milestone

Comments

@cyri113
Copy link
Contributor

cyri113 commented Jul 6, 2023

Problem

We have no standardised linter, which means that every repositories coding standards may defer. This makes it more of a challenge to easily work on multiple repositories. Our CI currently runs this process using super-linter, so it will be necessary for our services to meet the same standard, else the CI will fail.

Solution

We will use super-linter, in order to validate that our code meets certain standards. The library support almost every codebase, making it ideal for our use case.

Tasks

  • Adapt our codebase in order to validate the following command:
docker run -e RUN_LOCAL=true -e TYPESCRIPT_DEFAULT_STYLE=prettier -e VALIDATE_DOCKERFILE_HADOLINT=false -v $(pwd):/tmp/lint github/super-linter:slim-latest

Prerequisites

@cyri113 cyri113 mentioned this issue Jul 6, 2023
7 tasks
@cyri113 cyri113 added this to the CI Sprint #1 milestone Jul 6, 2023
@scientiststwin scientiststwin linked a pull request Aug 2, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants