Skip to content

Commit 92c8675

Browse files
committed
Update to v0.3.0:
* Update fmt/spdlog * Move packages from testStage to EmscriptenStage
1 parent 0134171 commit 92c8675

File tree

15 files changed

+41
-47
lines changed

15 files changed

+41
-47
lines changed

.github/workflows/macos.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ jobs:
8080
mv Frontend.wasm-Darwin-main.tar.xz Frontend.wasm-Darwin-${version}.tar.xz
8181
8282
echo "Making sure the release ${version} is online"
83+
test -f docs/ReleaseNotes/${version}.md
8384
gh release create "${version}" --title "${version}" --notes-file "docs/ReleaseNotes/${version}.md" || true
8485
gh release upload "${version}" "Frontend.wasm-Darwin-${version}.tar.xz" || true
8586

.github/workflows/ubuntu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ jobs:
8383
mv Frontend.wasm-Linux-main.tar.xz Frontend.wasm-Linux-${version}.tar.xz
8484
8585
echo "Making sure the release ${version} is online"
86+
test -f docs/ReleaseNotes/${version}.md
8687
gh release create "${version}" --title "${version}" --notes-file "docs/ReleaseNotes/${version}.md" || true
8788
gh release upload "${version}" Frontend.wasm-Linux-${version}.tar.xz || true
8889

.github/workflows/windows-debug-deploy.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
shell: cmd
5555
run: |
5656
call "%VCVARS%"
57-
cmake -S. -Bbuild -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_C_COMPILER=clang-cl -DENABLE_PACKAGING=ON -DCMAKE_BUILD_TYPE=Debug -DCPACK_PACKAGE_FILE_NAME=frontend -G Ninja -DCPACK_PACKAGE_FILE_NAME=frontend.wasm
57+
cmake -S. -Bbuild -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_C_COMPILER=clang-cl -DENABLE_PACKAGING=ON -DCMAKE_BUILD_TYPE=Debug -DCPACK_PACKAGE_FILE_NAME=frontend.wasm -G Ninja
5858
5959
- name: Build
6060
working-directory: C:\Repo
@@ -90,6 +90,7 @@ jobs:
9090
mv Frontend.wasm-Windows-main-Debug.tar.xz Frontend.wasm-Windows-${version}-Debug.tar.xz
9191
9292
echo "Making sure the release ${version} is online"
93+
test -f docs/ReleaseNotes/${version}.md
9394
gh release create "${version}" --title "${version}" --notes-file "docs/ReleaseNotes/${version}.md" || true
9495
gh release upload "${version}" Frontend.wasm-Windows-${version}-Debug.tar.xz || true
9596

.github/workflows/windows.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ jobs:
9292
mv Frontend.wasm-Windows-main-Release.tar.xz Frontend.wasm-Windows-${version}-Release.tar.xz
9393
9494
echo "Making sure the release ${version} is online"
95+
test -f docs/ReleaseNotes/${version}.md
9596
gh release create "${version}" --title "${version}" --notes-file "docs/ReleaseNotes/${version}.md" || true
9697
gh release upload "${version}" Frontend.wasm-Windows-${version}-Release.tar.xz || true
9798

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
cmake_minimum_required(VERSION 3.15)
22
project(
33
Frontend.wasm
4-
VERSION 0.2.0
4+
VERSION 0.3.0
55
LANGUAGES CXX)
66

77
configure_file(docs/ReleaseNotes/version.in
@@ -28,7 +28,7 @@ include(${modules}/ConanHelpers.cmake)
2828
# Create the profile from variables known during configure
2929
setup_conan_profile(VARIABLE frontend_conan_profile)
3030
# This helps with packaging
31-
set(FRONTEND.WASM_CONAN_REQUIRES_PACKAGES spdlog/1.8.0 fmt/7.1.3)
31+
set(FRONTEND.WASM_CONAN_REQUIRES_PACKAGES spdlog/1.9.2 fmt/8.1.1)
3232
find_conan_packages(REQUIRES ${FRONTEND.WASM_CONAN_REQUIRES_PACKAGES} PROFILE
3333
${frontend_conan_profile})
3434

docs/ReleaseNotes/.gitignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Ignore all files named (wherever they are):
2+
.DS_Store
3+
.log
4+
5+
# Generated by CMake
6+
version

docs/ReleaseNotes/v0.3.0.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# News #
2+
3+
## Housekeeping ##
4+
5+
* Update fmt to 8.1.1
6+
* Update spdlog to 1.9.2
7+
* Link against Tolc::Parser 0.2.0

src/Helpers/Embind/checkType.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,10 @@ extractRegisterCommands(IR::Type const& type, EmbindProxy::TypeInfo& typeInfo) {
121121
container && noneOfIsConst(container->m_containedTypes)) {
122122
if (auto s = getRegisterString(container->m_container)) {
123123
auto typeString = Builders::buildTypeString(type, "_");
124-
auto registerCmd = fmt::format(
125-
s.value(), Builders::getTemplateParameters(type), typeString);
124+
auto registerCmd =
125+
fmt::format(fmt::runtime(s.value()),
126+
Builders::getTemplateParameters(type),
127+
typeString);
126128

127129
registerCmd += addElementsIfNecessary(
128130
*container, type.m_representation, typeString, typeInfo);

tests/CMakeLists.txt

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
include_guard()
22

33
include(${modules}/GetParser.cmake)
4-
5-
set(parser_asset_name "Parser-${CMAKE_SYSTEM_NAME}-main")
6-
if(${CMAKE_HOST_SYSTEM_NAME} STREQUAL Windows)
7-
set(parser_asset_name "${parser_asset_name}-${CMAKE_BUILD_TYPE}")
8-
endif()
9-
get_parser(ASSET_NAME ${parser_asset_name}.tar.xz)
4+
get_parser(VERSION v0.2.0)
105

116
# Set the include path for the system library in the variable
127
# We are using the standard library shipped
@@ -55,11 +50,14 @@ configure_file(
5550
TestUtil/include/TestStage/paths.cpp.in
5651
${CMAKE_CURRENT_LIST_DIR}/TestUtil/include/TestStage/paths.cpp @ONLY)
5752

58-
5953
# Everything put in TestUtil/include is available
60-
add_library(TestUtil TestUtil/include/TestUtil/embindStage.cpp TestUtil/include/TestUtil/parse.cpp TestUtil/include/TestStage/paths.cpp)
54+
add_library(
55+
TestUtil
56+
TestUtil/include/TestUtil/embindStage.cpp TestUtil/include/TestUtil/parse.cpp
57+
TestUtil/include/TestStage/paths.cpp)
6158
target_include_directories(TestUtil PUBLIC TestUtil/include)
62-
target_link_libraries(TestUtil PRIVATE Tolc::Frontend.wasm Tolc::Parser Catch2::Catch2 Tolc::Stage)
59+
target_link_libraries(TestUtil PRIVATE Tolc::Frontend.wasm Tolc::Parser
60+
Catch2::Catch2 Tolc::Stage)
6361
target_link_libraries(TestUtil PUBLIC IR::IR)
6462
find_package(fmt REQUIRED)
6563

@@ -77,9 +75,9 @@ endif()
7775

7876
# Before configuring the stage, we have to download node dependencies
7977
add_test(
80-
NAME NpmInstall
81-
WORKING_DIRECTORY ${test_stage}
82-
COMMAND ${npm_exe} install)
78+
NAME NpmInstall
79+
WORKING_DIRECTORY ${test_stage}/EmscriptenStage
80+
COMMAND ${npm_exe} install)
8381
set_tests_properties(NpmInstall PROPERTIES FIXTURES_SETUP PreTestStage)
8482

8583
# Create a test fixture for downloading dependencies in the test stage
@@ -88,11 +86,11 @@ add_test(
8886
WORKING_DIRECTORY ${test_stage}
8987
COMMAND ${CMAKE_COMMAND} -S. -Bbuild -GNinja)
9088
set_tests_properties(ConfigureTestStage PROPERTIES FIXTURES_SETUP TestStage)
91-
set_tests_properties(ConfigureTestStage PROPERTIES FIXTURES_REQUIRED PreTestStage)
89+
set_tests_properties(ConfigureTestStage PROPERTIES FIXTURES_REQUIRED
90+
PreTestStage)
9291

9392
foreach(
9493
test
95-
9694
Builders/attributeBuilder.cpp
9795
Builders/classBuilder.cpp
9896
Builders/enumBuilder.cpp
@@ -133,9 +131,8 @@ foreach(
133131
# userDefined.cpp
134132
# valarrays.cpp
135133
# variants.cpp
136-
vectors.cpp
137-
)
138-
# Ex: EmbindProxy/moduleFile.cpp -> moduleFile
134+
vectors.cpp)
135+
# Ex: EmbindProxy/moduleFile.cpp -> moduleFile
139136
get_filename_component(testName ${test} NAME_WLE)
140137

141138
create_catch2_test(

tests/testStage/CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,11 @@ project(
1010
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
1111

1212
include(cmake/GetEmscripten.cmake)
13-
include(cmake/GetNodeModules.cmake)
1413

1514
if(NOT emsdk_SOURCE_DIR)
1615
get_emscripten(VERSION 3.1.3)
1716
endif()
1817

19-
# Download and copy over to EmscriptenStage
20-
# package.json and node_modules
21-
get_node_modules()
22-
2318
# Get the variable 'target_name'
2419
# NOTE: This will be generated for each test
2520
include(cmake/TargetName.cmake)

tests/testStage/EmscriptenStage/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
!configureAndBuild.bat
1313
!defaultModule.test.js
1414
!package.json
15+
!package-lock.json
1516

1617
# Directories
1718
!cmake

tests/testStage/package-lock.json renamed to tests/testStage/EmscriptenStage/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"dependencies": {
3-
"jest": "^27.5.0"
4-
},
5-
"scripts": {
6-
"test": "jest"
3+
"jest": "^27.5.1"
74
}
85
}

tests/testStage/cmake/GetNodeModules.cmake

Lines changed: 0 additions & 10 deletions
This file was deleted.

tests/testStage/package.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)