Skip to content

bug: vector-db and llm-summary should not be default features #244

@aphoristicartist

Description

@aphoristicartist

Context

PR #242 adds vector-db and llm-summary to default features in cli/Cargo.toml:

default = ["document", "vector-db", "llm-summary"]

This pulls in candle-nn, ONNX runtime, reqwest, tokio full runtime, hf-hub for every cargo install infiniloom.

Impact

  • Massive binary size increase
  • Significant compile time increase
  • May fail on platforms without native deps (ONNX)
  • Users who don't need semantic search pay the full cost

Suggested Fix

Remove from default features. Keep as opt-in. The existing full feature can include them.

Files

  • cli/Cargo.toml
  • engine/Cargo.toml

Severity

Critical

Found during review of #242

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions