Update tests

Author: Torann

.travis.yml

@@ -1,10 +1,8 @@
 language: php
 
 php:
-  - 7.2
-  - 7.3
-  - 7.4
   - 8.0
+  - 8.1
 
 before_script:
   - curl -s http://getcomposer.org/installer | php

phpstan.neon

@@ -1,7 +1,6 @@
 parameters:
-    excludes_analyse:
+    reportUnmatchedIgnoredErrors: false
+    excludePaths:
         - vendor
-        - resources
     ignoreErrors:
         - '#Function config_path not found#'
-        - '#Access to an undefined property Torann\\LaravelRepository\\Repositories\\AbstractRepository::\$model#'

tests/Repositories/AbstractRepositoryTest.php

@@ -6,7 +6,21 @@
 
 class AbstractRepositoryTest extends TestCase
 {
-    protected $hits;
+    /**
+     * @test
+     */
+    public function preventInvalidUserInput()
+    {
+        $repo = $this->makeRepository();
+
+        $repo->builderMock
+            ->shouldReceive('paginate')->once()
+            ->with(15, ['*'], 'page', 0)
+            ->andReturn(true);
+
+        // Ensure the package casts the per page limit correctly and returns the default 15
+        $this->assertEquals(true, $repo->paginate('select *'));
+    }
 
     /**
      * @test
@@ -27,24 +41,24 @@ public function shouldGetAll()
      */
     public function testPluck()
     {
-        $expectedArray = [
+        $expected_array = [
             [
                 'title' => 'admin',
                 'name' => 'Bill',
             ],
             [
                 'title' => 'user',
                 'name' => 'Kelly',
-            ]
+            ],
         ];
 
         $repo = $this->makeRepository();
 
         $repo->builderMock
             ->shouldReceive('pluck')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->pluck('title', 'name'));
+        $this->assertEquals($expected_array, $repo->pluck('title', 'name'));
     }
 
     /**
@@ -80,7 +94,7 @@ public function testSimplePaginate()
      */
     public function testFind()
     {
-        $expectedArray = [
+        $expected_array = [
             'id' => 123,
             'email' => 'admin@mail.com',
             'name' => 'Bill',
@@ -90,17 +104,17 @@ public function testFind()
 
         $repo->builderMock
             ->shouldReceive('find')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->find($expectedArray['id']));
+        $this->assertEquals($expected_array, $repo->find($expected_array['id']));
     }
 
     /**
      * @test
      */
     public function testFindBy()
     {
-        $expectedArray = [
+        $expected_array = [
             'id' => 123,
             'email' => 'admin@mail.com',
             'name' => 'Bill',
@@ -111,21 +125,21 @@ public function testFindBy()
 
         $repo->builderMock
             ->shouldReceive('where')->once()
-            ->with('id', '=', $expectedArray['id'])->once()
+            ->with('id', '=', $expected_array['id'])->once()
             ->andReturn($query);
 
         $query->shouldReceive('first')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->findBy('id', $expectedArray['id']));
+        $this->assertEquals($expected_array, $repo->findBy('id', $expected_array['id']));
     }
 
     /**
      * @test
      */
     public function testFindAllBy()
     {
-        $expectedArray = [
+        $expected_array = [
             [
                 'id' => 123,
                 'email' => 'admin@mail.com',
@@ -135,7 +149,7 @@ public function testFindAllBy()
                 'id' => 124,
                 'email' => 'admin@mail.com',
                 'name' => 'Todd',
-            ]
+            ],
         ];
 
         $repo = $this->makeRepository();
@@ -147,9 +161,9 @@ public function testFindAllBy()
             ->andReturn($query);
 
         $query->shouldReceive('get')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->findAllBy('email', 'admin@mail.com'));
+        $this->assertEquals($expected_array, $repo->findAllBy('email', 'admin@mail.com'));
     }
 
     /**
@@ -159,7 +173,7 @@ public function testFindAllByArray()
     {
         $ids = [1, 33];
 
-        $expectedArray = [
+        $expected_array = [
             [
                 'id' => 1,
                 'email' => 'admin@mail.com',
@@ -169,7 +183,7 @@ public function testFindAllByArray()
                 'id' => 33,
                 'email' => 'admin@mail.com',
                 'name' => 'Todd',
-            ]
+            ],
         ];
 
         $repo = $this->makeRepository();
@@ -181,22 +195,22 @@ public function testFindAllByArray()
             ->andReturn($query);
 
         $query->shouldReceive('get')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->findAllBy('id', $ids));
+        $this->assertEquals($expected_array, $repo->findAllBy('id', $ids));
     }
 
     /**
      * @test
      */
     public function testFindWhere()
     {
-        $expectedArray = [
+        $expected_array = [
             [
                 'id' => 123,
                 'email' => 'admin@mail.com',
                 'name' => 'Bill',
-            ]
+            ],
         ];
 
         $repo = $this->makeRepository();
@@ -205,10 +219,10 @@ public function testFindWhere()
             ->shouldReceive('where')->once()
             ->with('id', '=', 123)->once()
             ->shouldReceive('get')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->findWhere([
-            'id' => 123
+        $this->assertEquals($expected_array, $repo->findWhere([
+            'id' => 123,
         ]));
     }
 
@@ -217,12 +231,12 @@ public function testFindWhere()
      */
     public function testFindWhereWithConditions()
     {
-        $expectedArray = [
+        $expected_array = [
             [
                 'id' => 123,
                 'email' => 'admin@mail.com',
                 'name' => 'Bill',
-            ]
+            ],
         ];
 
         $repo = $this->makeRepository();
@@ -231,10 +245,10 @@ public function testFindWhereWithConditions()
             ->shouldReceive('where')->once()
             ->with('id', '<', 123)->once()
             ->shouldReceive('get')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->findWhere([
-            ['id', '<', 123]
+        $this->assertEquals($expected_array, $repo->findWhere([
+            ['id', '<', 123],
         ]));
     }
 
@@ -266,7 +280,7 @@ public function testCacheCallbackWithCache()
      */
     public function testFindUsingScope()
     {
-        $expectedArray = [
+        $expected_array = [
             [
                 'id' => 123,
                 'email' => 'admin@mail.com',
@@ -278,7 +292,7 @@ public function testFindUsingScope()
                 'email' => 'admin@mail.com',
                 'name' => 'Todd',
                 'is_admin' => true,
-            ]
+            ],
         ];
 
         $repo = $this->makeRepository();
@@ -290,8 +304,8 @@ public function testFindUsingScope()
             ->andReturn($query);
 
         $query->shouldReceive('get')->once()
-            ->andReturn($expectedArray);
+            ->andReturn($expected_array);
 
-        $this->assertEquals($expectedArray, $repo->adminOnlyScope()->all());
+        $this->assertEquals($expected_array, $repo->adminOnlyScope()->all());
     }
 }