🎀 Introduce Nix linting (#8)

This prevents dead nix code and improves overall code style consistency.

Author: aaronmondal

flake-module.nix

@@ -1,4 +1,4 @@
-{ lib, self, flake-parts-lib, ... }:
+{ lib, flake-parts-lib, ... }:
 let
   inherit (lib)
     mkOption

flake.nix

@@ -34,17 +34,21 @@
       # nixpkgs used by nativelink as the the "global" nixpkgs. We do this by
       # setting `nixpkgs.follows = "nativelink/nixpkgs"` above.
 
-      inputs.flake-utils.follows = "flake-utils";
-      inputs.flake-parts.follows = "flake-parts";
-      inputs.pre-commit-hooks.follows = "pre-commit-hooks";
+      inputs = {
+        flake-utils.follows = "flake-utils";
+        flake-parts.follows = "flake-parts";
+        pre-commit-hooks.follows = "pre-commit-hooks";
+      };
     };
     rules_ll = {
       url = "github:eomii/rules_ll/5ac0546db310da08d44f14271066e0b159611c25";
-      inputs.nixpkgs.follows = "nixpkgs";
-      inputs.flake-utils.follows = "flake-utils";
-      inputs.flake-parts.follows = "flake-parts";
-      inputs.pre-commit-hooks.follows = "pre-commit-hooks";
-      inputs.nativelink.follows = "nativelink";
+      inputs = {
+        nixpkgs.follows = "nixpkgs";
+        flake-utils.follows = "flake-utils";
+        flake-parts.follows = "flake-parts";
+        pre-commit-hooks.follows = "pre-commit-hooks";
+        nativelink.follows = "nativelink";
+      };
     };
     nix2container = {
       follows = "nativelink/nix2container";
@@ -54,7 +58,6 @@
   outputs =
     { self
     , nixpkgs
-    , flake-utils
     , pre-commit-hooks
     , flake-parts
     , nativelink
@@ -81,17 +84,16 @@
           , ...
           }:
           let
+            inherit (inputs.nativelink.packages.${system}) native-cli lre-cc nativelink-debug;
+
             tinfo6-bin = pkgs.callPackage ./tinfo6-bin.nix { };
 
             ncurses6-bin = pkgs.callPackage ./ncurses6-bin.nix { };
 
-            native-cli = inputs.nativelink.packages.${system}.native-cli;
-
             lre-mojo-cluster = pkgs.callPackage ./local-remote-execution/lre-mojo-cluster.nix {
               inherit native-cli;
             };
 
-            lre-cc = nativelink.packages.${system}.lre-cc;
             inherit (nix2container.packages.${system}.nix2container) buildImage;
 
             mojo = pkgs.callPackage ./mojo.nix {
@@ -114,7 +116,7 @@
 
             createWorker = pkgs.callPackage ./local-remote-execution/create-worker.nix {
               inherit buildImage self;
-              nativelink = nativelink.packages.${system}.nativelink-debug;
+              nativelink = nativelink-debug;
             };
 
             bazel = pkgs.writeShellScriptBin "bazel" ''
@@ -139,7 +141,7 @@
             };
             rules_ll.settings.llEnv =
               let
-                openssl = (pkgs.openssl.override { static = true; });
+                openssl = pkgs.openssl.override { static = true; };
               in
               rules_ll.lib.defaultLlEnv {
                 inherit pkgs;

lre-bazel.nix

@@ -4,14 +4,6 @@
 , ...
 }:
 
-let
-  # The specific commit to use
-  nativelinkCommit = "75105df746c626da76f74e412764e6755296a8ab";
-
-  # Base URL for GitHub access
-  githubBaseUrl = "github:TraceMachina/nativelink/";
-in
-
 writeShellScriptBin "lre-bazel" ''
   EXECUTOR=$(${kubectl}/bin/kubectl get gtw scheduler -o=jsonpath='{.status.addresses[0].value}')
   CACHE=$(${kubectl}/bin/kubectl get gtw cache -o=jsonpath='{.status.addresses[0].value}')

modules/rules_mojo.nix

@@ -2,7 +2,7 @@
 let
   inherit (lib) mkOption types;
 
-  inherit (pkgs) runCommand writeText git;
+  inherit (pkgs) runCommand git;
 
   processedActionEnvs = map (x: "build --@rules_mojo//mojo:" + x) config.mojoEnv;
 

pre-commit-hooks.nix

@@ -78,6 +78,8 @@
 
   # Nix
   nixpkgs-fmt.enable = true;
+  statix.enable = true;
+  deadnix.enable = true;
 
   # Vale
   vale = {

templates/default/flake.nix

@@ -34,44 +34,48 @@
       # nixpkgs used by nativelink as the the "global" nixpkgs. We do this by
       # setting `nixpkgs.follows = "nativelink/nixpkgs"` above.
 
-      inputs.flake-utils.follows = "flake-utils";
-      inputs.flake-parts.follows = "flake-parts";
-      inputs.pre-commit-hooks.follows = "pre-commit-hooks";
+      inputs = {
+        flake-utils.follows = "flake-utils";
+        flake-parts.follows = "flake-parts";
+        pre-commit-hooks.follows = "pre-commit-hooks";
+      };
     };
     rules_ll = {
       # Keep this commit in sync with the rules_ll commit in `MODULE.bazel`.
       url = "github:eomii/rules_ll/5ac0546db310da08d44f14271066e0b159611c25";
-      inputs.nixpkgs.follows = "nixpkgs";
-      inputs.flake-utils.follows = "flake-utils";
-      inputs.flake-parts.follows = "flake-parts";
-      inputs.pre-commit-hooks.follows = "pre-commit-hooks";
-      inputs.nativelink.follows = "nativelink";
+      inputs = {
+        nixpkgs.follows = "nixpkgs";
+        flake-utils.follows = "flake-utils";
+        flake-parts.follows = "flake-parts";
+        pre-commit-hooks.follows = "pre-commit-hooks";
+        nativelink.follows = "nativelink";
+      };
     };
     nix2container = {
       follows = "nativelink/nix2container";
     };
     rules_mojo = {
       # Keep this commit in sync with the rules_mojo commit in `MODULE.bazel`
       url = "github:TraceMachina/rules_mojo/<TODO: Specify rules_mojo commit>";
-      inputs.nixpkgs.follows = "nixpkgs";
-      inputs.flake-utils.follows = "flake-utils";
-      inputs.flake-parts.follows = "flake-parts";
-      inputs.pre-commit-hooks.follows = "pre-commit-hooks";
-      inputs.nativelink.follows = "nativelink";
-      inputs.rules_ll.follows = "rules_ll";
+      inputs = {
+        nixpkgs.follows = "nixpkgs";
+        flake-utils.follows = "flake-utils";
+        flake-parts.follows = "flake-parts";
+        pre-commit-hooks.follows = "pre-commit-hooks";
+        nativelink.follows = "nativelink";
+        rules_ll.follows = "rules_ll";
+      };
     };
   };
 
   outputs =
     { self
     , nixpkgs
-    , flake-utils
     , pre-commit-hooks
     , flake-parts
     , nativelink
     , rules_ll
     , rules_mojo
-    , nix2container
     , ...
     } @ inputs:
     flake-parts.lib.mkFlake { inherit inputs; }
@@ -92,6 +96,9 @@
           , lib
           , ...
           }:
+          let
+            inherit (inputs.nativelink.packages.${system}) lre-cc;
+          in
           {
             _module.args.pkgs = import self.inputs.nixpkgs {
               inherit system;
@@ -100,14 +107,14 @@
               # config.cudaSupport = true;
             };
             local-remote-execution.settings = {
-              inherit (nativelink.packages.${system}.lre-cc.meta) Env;
+              inherit (lre-cc.meta) Env;
             };
             pre-commit.settings = {
               hooks = import ./pre-commit-hooks.nix { inherit pkgs; };
             };
             rules_ll.settings.llEnv =
               let
-                openssl = (pkgs.openssl.override { static = true; });
+                openssl = pkgs.openssl.override { static = true; };
               in
               rules_ll.lib.defaultLlEnv {
                 inherit pkgs;
@@ -116,12 +123,12 @@
               };
             rules_mojo.settings.mojoEnv = rules_mojo.lib.defaultMojoEnv {
               inherit pkgs;
-              mojo = inputs.rules_mojo.packages.${system}.mojo;
+              inherit (inputs.rules_mojo.packages.${system}) mojo;
             };
             packages = {
-              lre-mojo = rules_mojo.packages.${system}.lre-mojo;
-              lre-cc = nativelink.packages.${system}.lre-cc;
-              nativelink-worker-lre-mojo = rules_mojo.packages.${system}.lre-mojo;
+              inherit lre-cc;
+              inherit (inputs.rules_mojo.packages.${system}) lre-mojo;
+              nativelink-worker-lre-mojo = lre-mojo;
             };
             devShells.default = pkgs.mkShell {
               nativeBuildInputs = [