Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More use of generic templates #120

Open
cstewart87 opened this issue Jun 2, 2014 · 1 comment
Open

More use of generic templates #120

cstewart87 opened this issue Jun 2, 2014 · 1 comment

Comments

@cstewart87
Copy link
Member

Working on adding a new top-level component ('Assemblies', 'Stacks', 'Offerings', etc.) I caught myself doing a lot of copying and pasting, especially with templates. Then, after clicking through the components I realized there's some inconsistencies with layout (button placement, message placement).

I'm hoping there's a way to have some more generic templates, with names like 'topComponentTemplate', 'subComponentTemplate', 'componentList', 'componentTable', etc. These templates would contain a base for what our common layout should be (styling, placement, etc.) and when adding a new component, the only requirement would be to create a new view, and render the template with appropriate titles, collections, messages, etc.

If there are reasons for avoiding this approach, please share. I feel if we can move in this directions, it would help decrease the time to add new features, as well as keep a more consistent design throughout our application.

@lifeBCE
Copy link

lifeBCE commented Jun 5, 2014

Agreed. As part of the application refactor, we need to go through a series of DRY runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants