From 02a0eeff1e0881654ec24d36a8e6655c0f59e81d Mon Sep 17 00:00:00 2001
From: Tino Koch <17991193+Tinoooo@users.noreply.github.com>
Date: Mon, 6 Jan 2025 21:36:37 +0100
Subject: [PATCH] chore: removed prop defaults for scanline effect, improved
 blendMode watcher

---
 src/core/pmndrs/ScanlinePmndrs.vue | 28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/src/core/pmndrs/ScanlinePmndrs.vue b/src/core/pmndrs/ScanlinePmndrs.vue
index 5246c4b3..f485d913 100644
--- a/src/core/pmndrs/ScanlinePmndrs.vue
+++ b/src/core/pmndrs/ScanlinePmndrs.vue
@@ -1,4 +1,5 @@
 <script lang="ts" setup>
+import { watch } from 'vue'
 import type { BlendFunction } from 'postprocessing'
 import { ScanlineEffect } from 'postprocessing'
 import { makePropWatchers } from '../../util/prop'
@@ -26,14 +27,7 @@ export interface ScanlinePmndrsProps {
   opacity?: number
 }
 
-const props = withDefaults(
-  defineProps<ScanlinePmndrsProps>(),
-  {
-    density: 1.25,
-    opacity: 1.0,
-    scrollSpeed: 0.0,
-  },
-)
+const props = defineProps<ScanlinePmndrsProps>()
 
 const { pass, effect } = useEffectPmndrs(() => new ScanlineEffect(props), props)
 
@@ -42,11 +36,27 @@ defineExpose({ pass, effect })
 makePropWatchers(
   [
     [() => props.blendFunction, 'blendMode.blendFunction'],
-    [() => props.opacity, 'blendMode.opacity.value'],
     [() => props.density, 'density'],
     [() => props.scrollSpeed, 'scrollSpeed'],
   ],
   effect,
   () => new ScanlineEffect(),
 )
+
+watch(
+  [() => props.opacity],
+  () => {
+    if (props.opacity !== undefined) {
+      effect.value?.blendMode.setOpacity(props.opacity)
+    }
+    else {
+      const plainEffect = new ScanlineEffect()
+      effect.value?.blendMode.setOpacity(plainEffect.blendMode.getOpacity())
+      plainEffect.dispose()
+    }
+  },
+  {
+    immediate: true,
+  },
+)
 </script>