Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI handler for Flatpak is not working #6483

Open
xoriole opened this issue Oct 22, 2021 · 5 comments · May be fixed by flathub/org.tribler.Tribler#19
Open

URI handler for Flatpak is not working #6483

xoriole opened this issue Oct 22, 2021 · 5 comments · May be fixed by flathub/org.tribler.Tribler#19
Assignees

Comments

@xoriole
Copy link
Contributor

xoriole commented Oct 22, 2021

The URI handler for magnet links is not working for the Flatpak installation of Tribler. Tribler does open but the start download dialog is not shown.

@xoriole xoriole added this to the Backlog milestone Oct 22, 2021
@xoriole xoriole self-assigned this Nov 23, 2023
@qstokkink qstokkink removed this from the Backlog milestone Aug 23, 2024
@qstokkink
Copy link
Contributor

qstokkink commented Oct 30, 2024

It would be nice to create a bleeding-edge flatpak build in a GitHub Action to check issues like this. I think we can make a test setup that uses "Git sources", see https://docs.flatpak.org/en/latest/module-sources.html#git-sources

Of course, that would be different from the "official" Flatpak (https://github.com/flathub/org.tribler.Tribler), which should use github.com/Tribler/tribler/releases URLs.


Update: I tried getting the basic Flatpak to work but I ran into an issue. Once that is resolved, I can resume work on this issue.

@qstokkink qstokkink self-assigned this Nov 1, 2024
@qstokkink
Copy link
Contributor

qstokkink commented Nov 12, 2024

I got a Flatpak build running and I can confirm that this doesn't work. However, I also checked with the .deb file and this also doesn't work. Apparently our entire Debian (Ubuntu) build process is broken.

@qstokkink
Copy link
Contributor

qstokkink commented Nov 12, 2024

Wait, hold on. It does work with the latest 8.0.3 pre-release from tribler.org. Something may have been recently broken. After a terminal restart this did work again. Don't ask me why.

@qstokkink
Copy link
Contributor

Alright, I got it working 🎉 However, I did not require any fixes to Tribler itself. I only needed changes in the org.tribler.Tribler.yaml.

I'll park my fix in https://github.com/qstokkink/tribler/tree/add_flatpak_testbuild if anyone wants to see how I got it working locally (note that this is now tied to my local filesystem and not the official Tribler release URL - this still has to be changed).

CC: @overflw when we hit the stable version of the 8 series the branch above has the basis for the required .yaml file, including the fix for this issue.

@qstokkink qstokkink changed the title URI handler for Flatpak is not working [Fixed, pending release] URI handler for Flatpak is not working Nov 12, 2024
@qstokkink qstokkink changed the title [Fixed, pending release] URI handler for Flatpak is not working URI handler for Flatpak is not working Nov 13, 2024
@qstokkink
Copy link
Contributor

Actually, the fix for this particular issue can be backported. I made a PR on the flathub repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants