Allow input of faction id by hand when searching

[wodim]

When you search for NPCs, there's a list of factions to pick from but it's far from complete.

Besides if you go to the page of a faction that's not on that list, like Ambient, and click the Filter these results button:

You just get an error:

So 1) a filter option, Faction ID, should be added, and 2) (necessarily) factions that are not on that incomplete list should be allowed to be used as filters

Thanks for keeping aowow alive!

[jackpoz]

Factions are defined at https://github.com/TrinityCore/aowow/blob/master/static/js/locale_enus.js#L3561-L3577 . Which factions are missing ?

[wodim]

I showed an example: Ambient

Another: Prey

[Sarjuuk]

it is indeed a predefined list and as such only values on it are accepted by the filter.

unsure if all factions should be in it.

[wodim]

Any good reason it shouldn't be possible to find things by faction ID?

[Faq]

unsure if all factions should be in it.

Just wondering why all factions should not be in it? Performance or other reasons?

[wodim]

This "database viewer" hides a lot of data (like certain npcs, spells...) arbitrarily. I've asked many times and I never got a straight answer.

[jackpoz]

It should show to users only what retail players can see on sites like wowhead and to staff what blizzard employees would see on their internal wowhead-style site.

It doesn't make much sense to show the same to every different role.