Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identified and mitigated: CToken.sol vulnerability with ERC677/ERC777 tokens #14

Open
dacarva opened this issue Jan 6, 2023 · 0 comments
Open

Identified and mitigated: CToken.sol vulnerability with ERC677/ERC777 tokens #14

dacarva opened this issue Jan 6, 2023 · 0 comments

Comments

@dacarva
Copy link
Member

dacarva commented Jan 6, 2023

The current implementation of the protocol has a potential reentrancy vulnerability when a ERC677 or ERC777 token is listed as the underlying token of the CToken.

https://github.com/Tropykus/protocol/blob/c88d0baa0a91235cd61716f3140d07ee9ba7ad4e/contracts/CToken.sol#L1449-L1454

The deployed markets at the moment do not interact with such tokens and are not subject to the vulnerability. A proposal for future listings has been added in the following commit: 97ae23b

https://github.com/Tropykus/protocol/blob/97ae23b3ef15ddadd5f6dd9c6bedf7570beed998/contracts/CToken.sol#L1450-L1455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dacarva