Replies: 2 comments 5 replies
-
I've faced this problem too, so I decided to make a project that somewhat fixes it, by not using a scraper in the first place, because that seems somewhat inefficient, it's not finished yet. I'm planning to add other lyrics sources to it, because MusixMatch in general sucks. LyricsFind seems somewhat reliable for this project, and I feel like we can use it to fix this issue above. For example, Money Trees by Kendrick Lamar does exists on LyricsFind, and I plan to add this source too. To be fair, I'm really busy these days, so I don't get that much time to work on this project 😅. But I'm trying my best to work on these little. If you want, we can work together on this feature. That'll be great ✨! |
Beta Was this translation helpful? Give feedback.
-
Oh, I wrote a fix just now out of sheer boredom. Do you want me to send a pull request? |
Beta Was this translation helpful? Give feedback.
-
Hey, first off, great concept, and I'm really flattered for the mention in your Readme. I was looking through your code to try and get some posters for myself. I wasn't able to get the lyrics for quite a few songs, like Money Trees by Kendrick Lamar. I was poking through the lyrics fetcher to see how you're going about it and I saw that you were using Beautifulsoup to get the website content for the lyrics.
Speaking from personal experience, using the class name to get the divs containing the lyrics are you are in
cols = soup.findAll(class_="lyrics__content__ok", string=True)
might not be the best idea as these websites often have computer generated class names, which means your website might break every time they decide to update the website. I know it because I faced the same issue with a Google Meet automator that I made a few years ago.You could instead look into finding divs with words that always occur in the lyrics content, like "Verse", and try finding the parent class/div for the same. Just a few ideas for you to explore.
Beta Was this translation helpful? Give feedback.
All reactions