Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #3

Open
jumpjack opened this issue Oct 11, 2022 · 4 comments
Open

Typos #3

jumpjack opened this issue Oct 11, 2022 · 4 comments

Comments

@jumpjack
Copy link

I think I found some typos:

  • a missing space between number and unit of measure
  • a missing header
  • some missing units of measure
  • inconsistent placement of "add" button (sometimes before, sometimes after the lists they refer to)

image

@TrystanLea
Copy link
Owner

Happy to accept a pull request with fixes for these if you make them. Everything apart from changing the location of the Add buttons, I'd prefer those left as they are. Thank you

@TrystanLea
Copy link
Owner

Also 'count' header needs to be left omitted due to limited screen space. It could be a 'title' mouse over tooltip perhaps..

@jumpjack
Copy link
Author

jumpjack commented Oct 11, 2022

But if I (now) understand correctly, the empty header is not the number of elements: it's the element the window/door refers to.
And "air changes per hour" are not m3, but how many times the total air volume is exchanged per hour, right?

@TrystanLea
Copy link
Owner

Yes thats correct, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants