Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orientation #4

Open
jumpjack opened this issue Oct 27, 2022 · 1 comment
Open

Orientation #4

jumpjack opened this issue Oct 27, 2022 · 1 comment

Comments

@jumpjack
Copy link

jumpjack commented Oct 27, 2022

If I understand correctly, current version does not take into account orientation of walls: it should affect power and energy calculation by a multiplying factor which, according to this document, for Italy varies from 0 to 20% (I don't know if it's the same everywhere):

image

Possible structure to use (add in config structure):

 orientationContribution = {
  S : 0,
  SW : 0.05,
  W: 0.1,
  NW: 0.15,
  N: 0.2,
  NE:  0.15,
  E:  0.1,
  SE: 0.05,
  not_appl: 1
 }

Current calculation:

            e.deltaT = room.temperature - e.temperature
            e.heat = e.wk * e.deltaT 
            e.kwh = e.wk * config.degreedays * 0.024

Updated:

            e.deltaT = room.temperature - e.temperature
            e.heat = config.orientationContribution[e.orientation] * e.wk * e.deltaT
            e.kwh = config. orientationContribution[e.orientation] *  e.wk * config.degreedays * 0.024

(note: e.orientation contents should be changed from "South" to "S", from "North" to "N" and so on:

image

Additionally, this line in model.js:

        if (e.orientation==undefined) e.orientation = ""

should be changed to:

        if (e.orientation==undefined) e.orientation = "not_appl"

I cannot add a pull request because I performed too many other changes to the original source to fit in just on PR.

@TrystanLea
Copy link
Owner

Thanks @jumpjack that's great! I've added a link to your fork on the front page readme, see https://github.com/TrystanLea/heatlossjs/blob/master/readme.md. Perhaps it would be worth starting an issue on this repository called heatlossjsITA with updates on the changes that you are making in your fork so that others can see your progress and if it makes sense build on your repository if that's the direction this should take..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants