Help with new extension PR #1639
-
|
I recently submitted a pull request for my small MIDI extension. Initially, it failed both validate and format, but I fixed validate. Since I'm relatively new to GitHub and this was my first extension pull request (I have prior extension development experience), I don't exactly know how to fix format, much less run prettier locally. My question is, does format need to be fixed for the extension to be published and if so how is it fixed? |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 6 replies
-
|
Yes formatting does need to be fixed, but you don't have to do it yourself. Me and GarboMuffin can do the prettier and other fixes for you, once we check it out. If your extension is done, let me know on your PR and I will check it out. |
Beta Was this translation helpful? Give feedback.
-
|
It's in a finished state that I'm satisfied with enough to put it on the gallery, but it has future potential for some updates. The pull request is submitted, but I can't get prettier done. Thanks for the help! |
Beta Was this translation helpful? Give feedback.
-
|
I'd like to have my extension published to the gallery, but obviously that can't happen until prettier is fixed. How can I run that locally myself? I'm willing to learn and it'd be better on the long run if I'm able to do prettier on some future extensions. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
it can take from a few hours to over a year
…________________________________
From: Brackets-Coder ***@***.***>
Sent: Thursday, August 1, 2024 11:09 AM
To: TurboWarp/extensions ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [TurboWarp/extensions] Help with new extension PR (Discussion #1639)
How long do the pull requests normally take to get approved? I noticed I was at the back of the line of 103 other pull requests. Is there something I can do to help the traffic flow?
—
Reply to this email directly, view it on GitHub<#1639 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGM6GVOJED6DH6FPEXD6EH3ZPJFRDAVCNFSM6AAAAABL2NF65OVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMRRGM4TCNQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Ok. Good to know. I guess smaller extensions get pushed further down the list whereas bigger extensions like Pen+, AR, and Simple3D are more top priority but take longer to review? |
Beta Was this translation helpful? Give feedback.
-
|
not really 😕
…________________________________
From: Brackets-Coder ***@***.***>
Sent: Thursday, August 1, 2024 6:43 PM
To: TurboWarp/extensions ***@***.***>
Cc: Miyo ***@***.***>; Comment ***@***.***>
Subject: Re: [TurboWarp/extensions] Help with new extension PR (Discussion #1639)
Ok. Good to know. I guess smaller extensions get pushed further down the list whereas bigger extensions like Pen+, AR, and Simple3D are more top priority but take longer to review?
—
Reply to this email directly, view it on GitHub<#1639 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGM6GVO46YZQVERTCOKZMQ3ZPK2YTAVCNFSM6AAAAABL2NF65OVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMRRG4ZDKNY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
So are they all kind of the same when it comes to review times? |
Beta Was this translation helpful? Give feedback.
-
|
liking the ones you thing should be reviewed and maybe doing some reviews yourself
…________________________________
From: Brackets-Coder ***@***.***>
Sent: Thursday, August 1, 2024 6:45 PM
To: TurboWarp/extensions ***@***.***>
Cc: Miyo ***@***.***>; Comment ***@***.***>
Subject: Re: [TurboWarp/extensions] Help with new extension PR (Discussion #1639)
So are they all kind of the same when it comes to review times?
If these reviews take a while is there anything I can do to help get traffic flowing a little bit better?
—
Reply to this email directly, view it on GitHub<#1639 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGM6GVJ5BGRCRHFHI3M32GLZPK3BPAVCNFSM6AAAAABL2NF65OVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMRRG4ZDONQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Ok. I'll get started to liking, but how does reviewing extensions work? |
Beta Was this translation helpful? Give feedback.
-
|
if you dont know best leave it at just liking for now.
…________________________________
From: Brackets-Coder ***@***.***>
Sent: Thursday, August 1, 2024 6:48 PM
To: TurboWarp/extensions ***@***.***>
Cc: Miyo ***@***.***>; Comment ***@***.***>
Subject: Re: [TurboWarp/extensions] Help with new extension PR (Discussion #1639)
Ok. I'll get started to liking, but how does reviewing extensions work?
—
Reply to this email directly, view it on GitHub<#1639 (reply in thread)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BGM6GVK3LQ7ZWKBXS2EGNNDZPK3KZAVCNFSM6AAAAABL2NF65OVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTAMRRG4ZDSMY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
|
Some big ones that get merged quicker is because they're made by developers who have already merged extensions and are quite trusted to know what they are doing. So we push them to the finish line quicker without much thought. |
Beta Was this translation helpful? Give feedback.
Yes formatting does need to be fixed, but you don't have to do it yourself. Me and GarboMuffin can do the prettier and other fixes for you, once we check it out. If your extension is done, let me know on your PR and I will check it out.