Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-9464] Reverting URL encoding changes #79

Merged
merged 5 commits into from
Jul 25, 2023
Merged

[TT-9464] Reverting URL encoding changes #79

merged 5 commits into from
Jul 25, 2023

Conversation

mativm02
Copy link
Contributor

@mativm02 mativm02 commented Jul 18, 2023 •
edited
Loading

Description

Reverting URL encoding changes

Related Issue

https://tyktech.atlassian.net/browse/TT-9464?atlOrigin=eyJpIjoiYjg1OTNjZWE2OGI1NGJlZmJkNWUzZDE4YmNkMzAxZjUiLCJwIjoiaiJ9

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • I have reviewed the guidelines for contributing to this repository.
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mativm02 mativm02 changed the title Reverting URL encoding changes [TT-9464] Reverting URL encoding changes Jul 21, 2023
@sredxny sredxny self-requested a review July 24, 2023 14:09
@mativm02 mativm02 merged commit 10200b7 into main Jul 25, 2023
7 checks passed
@mativm02 mativm02 deleted the fix/encoded-urls branch July 25, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sredxny sredxny sredxny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mativm02 @sredxny