Reversed numbering when $num/$numc template is used for file name

[totrov]

Version

bbfd21b8

Platform

win

Steps to reproduce

Repro: set $num or $numc in setup in filename template; select playlist
Fix description: Replace (i + 1) with (SelectedVideos.Count - i) in DownloadMultipleSetupViewModel.cs

P.S. It is not clear how to contribute

Details

Expected: numbers go in ascending order from 1 in accordance with playlist order.
Actual: numbers go in descending order from max to 1.

Checklist

• I have looked through existing issues to make sure that this bug has not been reported before
• I have provided a descriptive title for this issue
• I have made sure that this bug is reproducible on the latest version of the application
• I have provided all the information needed to reproduce this bug as efficiently as possible
• I have sponsored this project
• I have not read any of the above and just checked all the boxes to submit the issue

[totrov]

not clear how to contribute because I can't push bugfix branch:
remote: Permission to Tyrrrz/YoutubeDownloader.git denied to totrov.

[totrov]

@Tyrrrz by the way, not only described fix is needed, but also add AsEnumerable() to
public IReadOnlyList AvailableVideoQualityPreferences { get; } =
Enum.GetValues().AsEnumerable().Reverse().ToArray();
You can create a branch for bugfixing and share rights, I'll create a PR

[Tyrrrz]

not clear how to contribute because I can't push bugfix branch: remote: Permission to Tyrrrz/YoutubeDownloader.git denied to totrov.

@totrov you need to make a fork first.

See this for more info: https://docs.github.com/en/get-started/exploring-projects-on-github/contributing-to-a-project

You can also just use the web interface if you need to edit a single file.

I can make the fix myself (thanks!) but I'll wait in case you want to submit a PR.