Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused code in Workspace creation #8

Open
zjkmxy opened this issue Sep 29, 2024 · 0 comments
Open

Unused code in Workspace creation #8

zjkmxy opened this issue Sep 29, 2024 · 0 comments

Comments

@zjkmxy
Copy link
Collaborator

zjkmxy commented Sep 29, 2024

The code purpose is unclear.

ndnts-aux/src/workspace/workspace.ts

Lines 35 to 37 in 3064dac

const clientID = opts.rootDoc.clientID;
opts.rootDoc.clientID = 0;
opts.rootDoc.clientID = clientID;

Also, opts.createNewDoc already handles clientID. No need to do it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zjkmxy