Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation onclick - once only #25

Open
fyodr opened this issue Sep 12, 2016 · 6 comments
Open

Animation onclick - once only #25

fyodr opened this issue Sep 12, 2016 · 6 comments

Comments

@fyodr
Copy link
Contributor

fyodr commented Sep 12, 2016

The animation ought to run only once after being clicked on. It now runs on an infinite loop after one click. This was great when we were just trying to get the thing to work, but it feels a little bit unpolished.

@bmccutchon
Copy link
Member

bmccutchon commented Sep 12, 2016

We might consider displaying it in an HTML5 <video> tag instead of a canvas. This would allow the user to have video controls at the bottom (play/pause, volume, etc). If we go that route, this issue depends on #6 (or a generalized version of #6).

@fyodr
Copy link
Contributor Author

fyodr commented Sep 12, 2016

If we use the server-generated version, then the server will have to generate every video the user watches. As I recall, we were minimizing server processing time by letting the user mess around on their own machine.

@bmccutchon
Copy link
Member

Yes, but the same thing generated on the server could be generated on the client. The only reason we’re doing it on the server is because you can’t save things to disk from the client; downloads must come from the server.

On Sep 12, 2016, at 4:22 PM, fyodr notifications@github.com wrote:

If we use the server-generated version, then the server will have to generate every video the user watches. As I recall, we were minimizing server processing time by letting the user mess around on their own machine.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #25 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AIRSTcVvZcuOxwWVUoXhbfNFZ0ewssIhks5qpcKygaJpZM4J7Cb-.

@fyodr
Copy link
Contributor Author

fyodr commented Sep 12, 2016

Fair enough.

Still, implementing on the server and downloading can be handled without wiring it into current canvas - as well as vice versa. In the interest of minimizing labor, integrating these services should be a lower priority than achieving both.

@bmccutchon
Copy link
Member

Um, actually, in the interests of minimizing labor, we shouldn’t write the same thing twice.

On Sep 12, 2016, at 4:34 PM, fyodr notifications@github.com wrote:

Fair enough.

Still, implementing on the server and downloading can be handled without wiring it into current canvas - as well as vice versa. In the interest of minimizing labor, integrating these services should be a lower priority than achieving both.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #25 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AIRSTS_43ahRIjH1miEG-s7LOewBTzeIks5qpcV4gaJpZM4J7Cb-.

@fyodr
Copy link
Contributor Author

fyodr commented Sep 12, 2016

I probably just have some bad assumptions about what is involved in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants