-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print segment name in Segmented MNL summary tables #59
Comments
Ah, good point. More generally, it would probably be helpful to print the table names and data filters whenever we're fitting any kind of model. (And since the segmentation is implemented as filters, that would automatically handle this case.) Approach 1: add to the top part of the summary table
Approach 2: just use print statements or log messages
@mxndrwgrdnr, does this fit with what you were thinking? I can work on it.. |
Ah, yes, that does make sense to think of it from the perspective of data filters. Approach 2 might be better for the time being then. |
PR #61 includes an implementation of Approach 2 above, for segmented MNL models only. |
Not sure if this should be done in choicemodels where the
summary_table()
object in created (here) or as a filler in between summary tables in the for loop here, but it would be super helpful to have the segments names shown when all submodels are being fitted.The text was updated successfully, but these errors were encountered: