fix(deployment): generic deployment script (#152)

## Introduction
A generic deployment script

## Resolution
* Refer to the `TARGET` and `VERSION` from GH environment variables.
* Simplified YML scripts.

---------

Co-authored-by: Abhi Markan <abhi.markan@ukexportfinance.gov.uk>

Author: abhi-markan

.github/workflows/deployment.yml

@@ -81,21 +81,23 @@ jobs:
         creds: ${{ secrets.AZURE_CREDENTIALS }}
 
     - name: CLI 📝
-      run: echo ACR=$(az acr show -n $(az resource list --resource-type 'Microsoft.ContainerRegistry/registries' --query '[0].name' -o tsv) --query loginServer | tr -d '"') >> $GITHUB_ENV
+      run: |
+        echo ACR=$(az acr show -n $(az resource list --resource-type 'Microsoft.ContainerRegistry/registries' --query '[0].name' -o tsv) --query loginServer -o tsv) >> $GITHUB_ENV
+        echo ACR_USER=$(az acr show -n $(az resource list --resource-type 'Microsoft.ContainerRegistry/registries' --query '[0].name' -o tsv) --query name -o tsv) >> $GITHUB_ENV
 
     - name: Defaults ✨
       uses: Azure/cli@v1.0.7
       with:
         inlineScript: |
           # Basic
           az configure --defaults location=${{ vars.REGION }}
-          az configure --defaults group=${{ vars.RESOURCE }}
+          az configure --defaults group=rg-${{ env.PRODUCT }}-${{ vars.TARGET }}-${{ vars.VERSION }}
 
     - name: ACR 🔐
       uses: azure/docker-login@v1
       with:
         login-server: ${{ env.ACR }}
-        username: ${{ secrets.ACR_USERNAME }}
+        username: ${{ env.ACR_USER }}
         password: ${{ secrets.ACR_PASSWORD }}
 
     - name: Artifacts 🗃️

.github/workflows/infrastructure.yml

@@ -261,7 +261,7 @@ jobs:
             --name ca-${{ env.PRODUCT }}-mdm-${{ env.TARGET }}-${{ vars.VERSION }} \
             --environment cae-${{ env.PRODUCT }}-${{ env.TARGET }}-${{ vars.VERSION }} \
             --registry-server cr${{ env.PRODUCT }}${{ env.TARGET }}${{ vars.VERSION }}.azurecr.io \
-            --registry-username $(az acr credential show -n cr${{ env.PRODUCT }}${{ env.TARGET }}${{ vars.VERSION }} --query username | tr -d '"') \
+            --registry-username $(az acr credential show -n cr${{ env.PRODUCT }}${{ env.TARGET }}${{ vars.VERSION }} --query username -o tsv) \
             --cpu 1.0 \
             --memory 2.0Gi \
             --min-replicas 1 \

.husky/commit-msg

@@ -8,4 +8,4 @@ npx commitlint --edit $1
 npx lint-staged
 
 printf "\n\n${YELLOW}Lint check 🎨${NC}\n\n"
-npm run lint
+npm run lint