update

Signed-off-by: chrismaree <christopher.maree@gmail.com>

Author: chrismaree

src/OevOracle.sol

@@ -37,7 +37,7 @@ contract OevOracle is AggregatorV3Interface, Ownable {
         (uint80 roundId, int256 answer, uint256 startedAt, uint256 updatedAt, uint80 answeredInRound) =
             baseAggregator.latestRoundData();
 
-        require(latestRound != roundId);
+        require(latestRound != roundId, "No update needed");
         if (msg.sender != updater && msg.sender != owner()) {
             require(block.timestamp - updatedAt >= permissionWindow, "In permissioned window");
         }
@@ -48,6 +48,11 @@ contract OevOracle is AggregatorV3Interface, Ownable {
         roundData[roundId] = RoundData(roundId, answer, startedAt, updatedAt, answeredInRound);
     }
 
+    function canUpdateAnswer() public view returns (bool) {
+        (uint256 roundId,,,,) = baseAggregator.latestRoundData();
+        return latestRound != roundId;
+    }
+
     function setUpdater(address _updater) public onlyOwner {
         updater = _updater;
     }

test/OevOracle.updateAnswer.sol

@@ -4,10 +4,19 @@ pragma solidity 0.8.17;
 import "./OevOracle.Common.sol";
 
 contract OevOracleUpdateAnswer is OevOracleCommon {
+    int256 newPrice = 1900 * 1e8;
+
+    function testUpdateWithNoDiffIsNoOp() public {
+        verifyOevOracleMatchesBaseAggregator();
+        assertFalse(oevOracle.canUpdateAnswer());
+        vm.expectRevert("No update needed");
+        oevOracle.updateAnswer();
+        verifyOevOracleMatchesBaseAggregator();
+    }
+
     function testUpdaterCanUpdateAnswer() public {
         verifyOevOracleMatchesBaseAggregator();
 
-        int256 newPrice = 1900 * 1e8;
         baseAggregator.updateAnswer(newPrice);
 
         vm.prank(permissionedUpdater);
@@ -17,7 +26,6 @@ contract OevOracleUpdateAnswer is OevOracleCommon {
     }
 
     function testAnyAccountCanUpdateAnswerAfterDelay() public {
-        int256 newPrice = 1900 * 1e8;
         baseAggregator.updateAnswer(newPrice);
 
         vm.expectRevert("In permissioned window");