-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of code from v2024.3.5.dev to current version #283
Comments
@MatthewPaskin, could you please grant me access to the SUEWS-STEBBS repository? |
done |
@MatthewPaskin, could you direct me to the STEBBS code for coupling with SUEWS? I see there are several Fortran files. I'll provide guidance on the coupling.
You may encounter such issue in a native Windows environment because the I recommend using WSL for supy development on Windows. It's essentially a Linux environment, and I can help you better if any issues arise. |
The main file that I have found a difference is in ./SUEWS/src/suews/src/suews_ctrl_driver.f95. It seems the structure of this has significantly changed. The notes on the implementation are as follows: @l.2914
My issue is just finding an equivalent in the new file as SUEWS_calc_main_DTS is no longer present in the file.
I am actually working on a Linux system but I am using pip to keep a cleaner python installation (rather than having multiple sources e.g. with python and conda). I have tried on my home system (Arch) and through WSL (Ubuntu) on my windows laptop and had the same issues each time. |
Hi @MatthewPaskin, let's park the dev env issue for now—as long as you're using Linux, that's great. Regarding the source code, which STEBBS file should I refer to? There are several in the repository. Please post a link to the file. |
I believe the STEBBS file to be added to SUEWS/src/suews/src is the STEBBS_f95dev/src/suews_phys_stebbs.f95 file. |
yes although on compilation the gocreate.sh (found in STEBBS_f95dev/sh/) modifies this file slightly e.g. on line 11. |
Hi @MatthewPaskin, I’m back from annual leave and have reviewed the STEBBS code. I noticed it uses a file-based approach for input and output with the main SUEWS code, writing results as external files. To make the coupled code more efficient and easier to maintain, I suggest the following:
Additionally, please use the Fortran extension in VS Code for navigation between definitions and references during development. Any questions, please let me know. |
I've created a branch for this work: https://github.com/UMEP-dev/SUEWS/tree/sunt05/issue283. The STEBBS source code has been copied from your repo: https://github.com/UMEP-dev/SUEWS/blob/sunt05/issue283/src/suews/src/suews_phys_stebbs.f95#L0-L1 Let's collaborate there. |
Hi @sunt05 , many thanks for taking a look at this. I will take a look at your suggestions and will keep in contact regarding this coupling. I noticed last week I am unable to commit to branches on this repository. Would it be possible to enable commits for this new branch? |
Hi @MatthewPaskin, I've added you to the SUEWS-dev team. You can now commit to the SUEWS repository. |
@sunt05, I think the code can either use a file approach but the subroutine stebbsonlinecouple looks as though it is already in the form you suggest. SUEWS/src/suews/src/suews_phys_stebbs.f95 Lines 669 to 670 in dca7fa2
|
Yes, I noticed this subroutine too, and it seems to be where the coupling could be improved. Additionally, examining the code at SUEWS/src/suews/src/suews_phys_stebbs.f95 Line 885 in dca7fa2
shows that the output is written as external files: SUEWS/src/suews/src/suews_phys_stebbs.f95 Lines 921 to 940 in dca7fa2
These could be stored explicitly as arrays following the SUEWS convention mentioned in my earlier post. |
Hi @sunt05. Part of the STEBBS module uses the radiation onto the building walls from BEERS which is separated by the cardinal wall directions, however STEBBS only takes a single value for wall radiation. This was previously processed externally in python and fed into STEBBS. Would you advise that in the new fortran module I calculate this value within the STEBBS f95 file after passing the BEERS output, or instead use python or calculate in a different f95 file before passing to the STEBBS file? Thanks |
Hi @MatthewPaskin, let's do this:
|
Describe the Issue
Some code for coupling a building energy model was added to version v2024.3.5.dev as can be found here: https://github.com/Urban-Meteorology-Reading/SUEWS-STEBBS
I am looking to make this same implementation in the newest version but significant changes have been made to the file SUEWS_ctrl_driver.f95 and I am struggling to identify where to make this new implementation.
Additional context
I am unable to compile the v2024.3.5.dev version due to an issue with numpy.distutils failing to import distutils.msvccompiler after make dev is called, despite this being available to my python environment.
The text was updated successfully, but these errors were encountered: