Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in compare_images results #26

Open
dwachsmuth opened this issue Aug 7, 2021 · 0 comments
Open

Bug in compare_images results #26

dwachsmuth opened this issue Aug 7, 2021 · 0 comments

Comments

@dwachsmuth
Copy link
Member

There seems to be a problem with how match/non-match results are allocated back to original rows, possibly when one of the categories (e.g. "possible match") is missing.

The following produces a "match" where there should be a "non-match" at 3/175/875 (row 27 in the input matches):

paths_low <- list.files("/Volumes/Data 2/Scrape photos/vancouver/kj", 
                        full.names = TRUE)
paths_high <- list.files("/Volumes/Data 2/Scrape photos/vancouver/ab", 
                         full.names = TRUE)

sigs_low <- create_signature(paths_low[1:20000])
sigs_high <- create_signature(paths_high[1:10000])
matches <- match_signatures(sigs_low, sigs_high)
matches <- identify_matches(matches)
confirmed <- compare_images(matches)
final_matches <- integrate_changes(matches, confirmed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant