Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Smell: test/components/stations #456

Closed
8 of 9 tasks
Anshuman0157 opened this issue Oct 4, 2024 · 1 comment · Fixed by #485
Closed
8 of 9 tasks

Code Smell: test/components/stations #456

Anshuman0157 opened this issue Oct 4, 2024 · 1 comment · Fixed by #485
Assignees
@Caleb-J-Murphy
Labels
Sprint 4 Task Team 3

Comments

@Anshuman0157
Copy link
Contributor

Anshuman0157 commented Oct 4, 2024 •
edited by Caleb-J-Murphy
Loading

Description

Task: Code Smell: components/stations.
Feature: [Code Smells] (#455)
Fix all 90 code smells located in the test folder, specifically the /game/components/station/ folder.

Dependencies

N/A

Milestones

List of steps that need to be completed for this task.

  • BenchTest.java (Oct. 9)
  • CookingComponentTest.java (Oct. 9)
  • FireExtinguisherHandlerComponentTest.java (Oct. 9)
  • IngredientStationHandlerComponentTest.java (Oct. 9)
  • StationChoppingComponentTest.java (Oct. 9)
  • StationCollectionComponentTest.java (Oct. 9)
  • StationCookingComponentTest.java (Oct. 9)
  • StationItemHandlerComponentTest.java (Oct. 9)
  • StationMealComponentTest.java (Oct. 9)

Completion Deadline: Oct. 9

Documentation

  • ...

Member
@Anshuman0157 Anshuman0157 mentioned this issue Oct 4, 2024
Closed
17 tasks
@Caleb-J-Murphy Caleb-J-Murphy self-assigned this Oct 8, 2024
@Caleb-J-Murphy
Copy link
Contributor

CookingComponentTest.java seems to have been commented out. Might need to bring this up mid sprint

Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: FireExtinguisherHandlerCompo…
ab222cb 
…nentTest.java
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: BenchTest.java
00712a9
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: BenchTest.java
7b21097
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: IngredientStationHandlerComp…
185535d 
…onentTest.java
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: StationChoppingComponentTest…
5525b64 
….java
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: StationCollectionComponentTe…
0da0199 
…st.java
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: StationCookingComponentTest.…
6cf88e1 
…java
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: StationItemHandlerComponentT…
cbf9320 
…est.java
Caleb-J-Murphy pushed a commit that referenced this issue Oct 8, 2024
#456 Fixed code smells and warnings for: StationItemHandlerComponentT…
acc125e 
…est.java
@Caleb-J-Murphy Caleb-J-Murphy mentioned this issue Oct 8, 2024
Merged
18 tasks
@Caleb-J-Murphy Caleb-J-Murphy linked a pull request Oct 8, 2024 that will close this issue
Team3/code smell components stations #485
Merged
18 tasks
@Caleb-J-Murphy Caleb-J-Murphy changed the title Code Smell: components/stations Code Smell: test/components/stations Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Caleb-J-Murphy Caleb-J-Murphy

Labels
Sprint 4 Task Team 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Team3/code smell components stations UQcsse3200/2024-studio-3
2 participants
@Anshuman0157 @Caleb-J-Murphy