Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Smells: components/npc #505

Closed
5 tasks done
Tracked by #455
Caleb-J-Murphy opened this issue Oct 10, 2024 · 0 comments · Fixed by #647
Closed
5 tasks done
Tracked by #455

Code Smells: components/npc #505

Caleb-J-Murphy opened this issue Oct 10, 2024 · 0 comments · Fixed by #647
Assignees
@Caleb-J-Murphy
Labels
Sprint 4 Task Team 3

Comments

@Caleb-J-Murphy
Copy link
Contributor

Caleb-J-Murphy commented Oct 10, 2024 •
edited
Loading

Description

Task: Code Smell: components/factories.
Feature: [Code Smells] (#455)
Fix all 4 code smells located in the main game folder, specifically the /game/components/factories/ folder.
Fix all 17 code smells located in the test folder, specifically the /game/components/factories/ folder.

Dependencies

N/A

Milestones

List of steps that need to be completed for this task.
Game Files

  • CustomerManager.java
  • GhostPositionManagerComponent.java

Test Files

  • CustomerComponentTest.java
  • CustomerManagerTest.java
  • PersonalCustomerEnumsTest.java

Completion Deadline: Oct. 17

Member
@Caleb-J-Murphy Caleb-J-Murphy mentioned this issue Oct 10, 2024
Closed
17 tasks
@Caleb-J-Murphy Caleb-J-Murphy self-assigned this Oct 16, 2024
Caleb-J-Murphy pushed a commit that referenced this issue Oct 16, 2024
#505 Fixed code smells for: CustomerManager.java
c614328
Caleb-J-Murphy pushed a commit that referenced this issue Oct 16, 2024
#505 Fixed code smells for: GhostPositionManagerComponent.java
4d9d607
Caleb-J-Murphy pushed a commit that referenced this issue Oct 16, 2024
#505 Fixed code smells for: CustomerComponentTest.java
2c94b30
Caleb-J-Murphy pushed a commit that referenced this issue Oct 16, 2024
#505 Fixed code smells for: CustomerManagerTest.java
49b31a9
Caleb-J-Murphy pushed a commit that referenced this issue Oct 16, 2024
#505 Fixed code smells for: PersonalCustomerEnumsTest.java
72dc9f8
@Caleb-J-Murphy Caleb-J-Murphy linked a pull request Oct 16, 2024 that will close this issue
Team3/code smells components npc #647
Merged
14 tasks
@Caleb-J-Murphy Caleb-J-Murphy mentioned this issue Oct 16, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Caleb-J-Murphy Caleb-J-Murphy

Labels
Sprint 4 Task Team 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Team3/code smells components npc UQcsse3200/2024-studio-3
1 participant
@Caleb-J-Murphy