Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Smells: components/cutscenes #652

Closed
28 tasks done
Tracked by #455
Caleb-J-Murphy opened this issue Oct 17, 2024 · 0 comments · Fixed by #658
Closed
28 tasks done
Tracked by #455

Code Smells: components/cutscenes #652

Caleb-J-Murphy opened this issue Oct 17, 2024 · 0 comments · Fixed by #658

Comments

@Caleb-J-Murphy
Copy link
Contributor

Caleb-J-Murphy commented Oct 17, 2024 •
edited
Loading

Description

Task: Code Smell: components/cutscenes.
Feature: Code Smells
Fix all 22 code smells located in the main game folder, specifically the /game/components/cutscenes/ folder.
Fix all 49 code smells located in the test game folder, specifically the /game/components/cutscenes/ folder.

Dependencies

N/A

Milestones

The game files that need to fixed:

  • BackstoryCutscene.java
  • Cutscene.java
  • CutsceneActions.java
  • CutsceneArea.java
  • CutsceneFactory.java
  • CutsceneScreenDisplay.java
  • CutsceneTextDisplay.java
  • Day2Cutscene.java
  • Day3Cutscene.java
  • IntroCutscene.java

The test files that need to be fixed:

  • AnimatedSceneTest.java
  • BackgroundCutsceneTest.java
  • BackstoryCutsceneDisplayTest.java
  • BackstoryCutsceneTest.java
  • BadEndCutsceneTest.java
  • CutsceneScreenDisplayTest.java
  • CutsceneTest.java
  • Day2CutsceneTest.java
  • Day3CutsceneTest.java
  • Day4CutsceneTest.java
  • GoodEndCutsceneTest.java
  • GoodEndTest.java
  • IntroCutsceneTest.java
  • LoseEndTest.java
  • MoralDay1CutsceneTest.java
  • MoralDay2CutsceneTest.java
  • MoralDay3CutsceneTest.java
  • MoralDay4CutsceneTest.java

Completion Deadline: Oct. 17

Documentation

  • ...

Member
@Caleb-J-Murphy Caleb-J-Murphy mentioned this issue Oct 17, 2024
Closed
17 tasks
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: BackstoryCutscene.java
3e3f0dc
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: Cutscene.java
54e6250
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneActions.java
7307f8d
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneArea.java
9a79d0e
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneFactory.java
a8cea43
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneScreenDisplay.java
5dbb2b7
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneTextDisplay.java
174d8cf
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: Day2Cutscene.java
5f5c587
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: Day3Cutscene.java
7803b55
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: IntroCutscene.java
f361d50
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: IntroCutscene.java
344680a
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: BackgroundCutsceneTest.java
d4c339c
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: BackstoryCutsceneTest.java
be3f5a2
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: BackstoryCutsceneTest.java
912d8b5
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneScreenDisplayTest.java
2ce6156
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed tests
9b3ec37
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: CutsceneTest.java
5311f41
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: Day2CutsceneTest.java
92c1795
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: Day3CutsceneTest.java
0692c9a
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: Day4CutsceneTest.java
6a237b2
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: GoodEndCutsceneTest.java
03c4d5e
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: GoodEndTest.java
c925019
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: IntroCutsceneTest.java
baaf096
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: LoseEndTest.java
767961c
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: MoralDay1CutsceneTest.java
e08ee20
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: MoralDay2CutsceneTest.java
6ce8753
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed code smells for: MoralDay4CutsceneTest.java
c8dcab8
Caleb-J-Murphy pushed a commit that referenced this issue Oct 17, 2024
#652 Fixed test cases
d3f488b
@Caleb-J-Murphy Caleb-J-Murphy mentioned this issue Oct 17, 2024
Merged
27 tasks
@Caleb-J-Murphy Caleb-J-Murphy linked a pull request Oct 17, 2024 that will close this issue
Team3/code smells componentscutscenes #658
Merged
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Team3/code smells componentscutscenes UQcsse3200/2024-studio-3
1 participant
@Caleb-J-Murphy