fix #15, add note to aqs_sampledurations documentation

Author: mccroweyclinton-EPA

MD5

@@ -1,6 +1,6 @@
 d3a7f7cc6aca27a043309d5bf9f32edc *codemeta.json
-0e3e29455c23b98008a4753685d335cd *cran-comments.md
-0e3e29455c23b98008a4753685d335cd *cran-comments.Rmd
+f6a3bb19c1f296f1c54a3b64fd62254a *cran-comments.md
+f6a3bb19c1f296f1c54a3b64fd62254a *cran-comments.Rmd
 b8d94ee4fbd2f34fd47fed05467f5337 *DESCRIPTION
 1dc95961c4c280f8645a65d15662725f *dev/contributing.md
 4fc13def6ec5d889261f1f22a13ba542 *dev/contributing.Rmd
@@ -91,7 +91,7 @@ a8f79ece8b275d2f60fc09a58239e661 *man/aqs_quarterlysummary_by_site.Rd
 4232385c24cb5041c7ad57ec9279a798 *man/aqs_sampledata_by_county.Rd
 d6bccf166ae844172cf9b241c89093e2 *man/aqs_sampledata_by_site.Rd
 a10c5684e68d35cebb418f849c058609 *man/aqs_sampledata_by_state.Rd
-14b482cdf2d7e5c75787fde9218110c2 *man/aqs_sampledurations.Rd
+a483627fe3673c8b006d8481179e7f53 *man/aqs_sampledurations.Rd
 f9d84d9671e9c011e40dcf3567f3aa47 *man/aqs_services_by_box.Rd
 9291322a3bd3a17248904a0bfcf32d2f *man/aqs_services_by_cbsa.Rd
 9ca1f01ed3c413b5c8cd1f9f2bec9f3d *man/aqs_services_by_county.Rd
@@ -119,7 +119,7 @@ bf2f1ad432ecccee3400afe533404113 *man/figures/lifecycle-superseded.svg
 7ce4525010156c02adaf819a8c835134 *man/RAQSAPI.Rd
 cba75186037b95121bfe7eeca1a1159d *NAMESPACE
 94c65e3824d4fd9ffa90ec73fed63596 *NEWS.md
-a2865412b0b90beed13d204fc6590e3f *R/AQSAPI_helperfunctions.R
+e6f3f0f0ea2ae4ac177d3d3ae0bef63c *R/AQSAPI_helperfunctions.R
 a3558975d0256839b174ab7868833075 *R/bybox.R
 bd8b36cc7325d4fc8b8ed894f0046678 *R/bycbsa.R
 253ea551f88c65c1c49feff3cb33f552 *R/bycounty.R
@@ -129,7 +129,7 @@ d82b1ff8ee144afca1879e5b8dc58840 *R/byma.R
 2e6e59d801dc3b6bd5e415ada7268469 *R/bystate.R
 8198ed65b99926d0ed9b07c49a1bf8e2 *R/deprecated.R
 87275ab3c5bd1af63ecfbd835ea8f53b *R/RAQSAPI-package.R
-c9fd9ac3f73645262f4c6665c370a9a8 *R/RAQSAPIlistfunctions.R
+77a42295baa4ba40cc3a409bed39f67b *R/RAQSAPIlistfunctions.R
 e6e3b87e48f4403642382987b0f40714 *R/setupfunctions.R
 6e659bb3bbf313dc819d4c029f0b22d0 *R/zzz.R
 8f51fe5ddf897afb20925542060627f7 *RAQSAPI.Rcheck/00_pkg_src/RAQSAPI/build/stage23.rdb
@@ -367,7 +367,7 @@ b299be1b0cc513f05fa0a8f952f76c38 *RAQSAPI.Rcheck/RAQSAPI/help/figures/lifecycle-
 984d67a7f6ecf5948c161ce0b1357cb3 *RAQSAPI.Rcheck/RAQSAPI/help/RAQSAPI.rdb
 721852fa3fededb2f3daf964ffef6a93 *RAQSAPI.Rcheck/RAQSAPI/help/RAQSAPI.rdx
 c57cbd3f9b8dd0562aecb7365e66c19e *RAQSAPI.Rcheck/RAQSAPI/html/00Index.html
-8b9362669af13540a86a3ac6cf22f99d *RAQSAPI.Rcheck/RAQSAPI/html/R.css
+a8edcce19d02f8a205d00dc812f36639 *RAQSAPI.Rcheck/RAQSAPI/html/R.css
 0fc456b08e2158655be64acd9c89fcdc *RAQSAPI.Rcheck/RAQSAPI/INDEX
 f191f333b866ab8dcb201f48270fe190 *RAQSAPI.Rcheck/RAQSAPI/Meta/features.rds
 8e6557ca03dc7d7484f868a1e095a51e *RAQSAPI.Rcheck/RAQSAPI/Meta/hsearch.rds
@@ -378,15 +378,15 @@ f191f333b866ab8dcb201f48270fe190 *RAQSAPI.Rcheck/RAQSAPI/Meta/features.rds
 12aced1f7b2dd6f0d2c8054e24271e0b *RAQSAPI.Rcheck/RAQSAPI/Meta/vignette.rds
 3fefa6fab6ae613528f4cecf39cfaf8c *RAQSAPI.Rcheck/RAQSAPI/NAMESPACE
 94c65e3824d4fd9ffa90ec73fed63596 *RAQSAPI.Rcheck/RAQSAPI/NEWS.md
-d6c68f1fe41ced6e98a766a3757313da *RAQSAPI.Rcheck/RAQSAPI/R/RAQSAPI
+c8bda207ff1759df0deb7a69220778a7 *RAQSAPI.Rcheck/RAQSAPI/R/RAQSAPI
 36d69a2778a803f2bd6a7ad605ac2dc7 *RAQSAPI.Rcheck/RAQSAPI/R/RAQSAPI.rdb
 e77fe25730503615857c360a01f2d17a *RAQSAPI.Rcheck/RAQSAPI/R/RAQSAPI.rdx
 dd65d70b425fb86f7c8b6d8841a837d8 *RAQSAPI.Rcheck/RAQSAPI/schemaorg.json
 44650d3802ce6c4eccbbfc02684e51a2 *RAQSAPI.Rcheck/RAQSAPI/WORDLIST
 9566921a96ff55c1a51b6eb898d25884 *RAQSAPI.Rcheck/tests/spelling.R
 0771ddcf9420162924460f9361ff8826 *RAQSAPI.Rcheck/tests/spelling.Rout
 f4e07eb82b9a00bae0c0177f4b861511 *RAQSAPI.Rcheck/tests/spelling.Rout.save
-14e3c5b3d49f164cf0bc8dcd3cf2fd78 *RAQSAPI.Rcheck/tests/startup.Rs
+4dcaf6e4698de3f0f55bad64d77cde5b *RAQSAPI.Rcheck/tests/startup.Rs
 846f989b5f8b7a32fa520e52b4675635 *RAQSAPI.Rcheck/tests/test-RAQSAPI.R.blob
 cb0e705ce06ab9db6aad083e91041d31 *RAQSAPI.Rcheck/tests/testthat.R
 7fbe889570d84987c39539878f32733a *RAQSAPI.Rcheck/tests/testthat.Rout.fail
@@ -403,7 +403,7 @@ f7ea691da1baf266047ed7af4b0c4629 *RAQSAPI.Rcheck/tests/testthat/test-bypqao.R
 3e2e78ef3cf7666c3c041ff1b5bec788 *RAQSAPI.Rcheck/tests/testthat/testthat-problems.rds
 a69de5455537022556f014579766be59 *RAQSAPI.Rproj
 cfb9487651a3162cdb4308fb94e30719 *RAQSAPI_2.0.5.tar.gz
-2ebf9afc2ea031d85d67ba4d3da009b4 *README.md
+e67079ab26d57115232487088b776c1e *README.md
 10f9e33622104f2df281fb4119a09d36 *README.Rmd
 7ed08f3fb96a77ec01c95c2ad7964250 *revdep/data.sqlite
 34952a5944548ea4fc132a9899f8e6ab *revdep/email.yml

R/AQSAPI_helperfunctions.R

@@ -1057,6 +1057,7 @@ aqsmultiyearparams <- function(parameter, bdate, edate, service, ...)
                     stateFIPS = ellipsis_args$stateFIPS,
                     countycode = ellipsis_args$countycode,
                     sitenum = ellipsis_args$sitenum,
+                    duration = ellipsis_args$duration,
                     service = service,
                     cbdate = ellipsis_args$cbdate,
                     cedate = ellipsis_args$cedate,

R/RAQSAPIlistfunctions.R

@@ -440,6 +440,10 @@ aqs_fields_by_service <- function(service, return_header = FALSE)
 #'                        item list that contains header information returned
 #'                        from the API server mostly used for debugging
 #'                        purposes in addition to the data requested.
+#' @note Not all sample durations that are available through AQS are available
+#'       through the AQS DataMart API, including certain calculated sample
+#'       durations. Only sample durations that are available through the
+#'       AQS DataMart API are returned.
 #' @return a tibble or an AQS_Data Mart_APIv2 S3 object of sample durations and
 #'         their associated duration codes
 #'                 (groups of parameters, i.e. "criteria" or "all").

README.md

@@ -37,7 +37,7 @@ status](https://www.r-pkg.org/badges/version/RAQSAPI)](https://CRAN.R-project.or
 downloads](https://cranlogs.r-pkg.org/badges/RAQSAPI)](https://cran.r-project.org/package=RAQSAPI)
 [![lifecycle](https://img.shields.io/badge/lifecycle-maturing-blue.svg)](https://www.tidyverse.org/lifecycle/#maturing)
 [![license](https://img.shields.io/badge/license-CC0-lightgrey.svg)](https://choosealicense.com/)
-“[![Last-changedate](https://img.shields.io/badge/last%20change-%202023--10--23-yellowgreen.svg)](/commits/master)”
+“[![Last-changedate](https://img.shields.io/badge/last%20change-%202023--10--27-yellowgreen.svg)](/commits/master)”
 <!-- badges: end -->
 
 # EPA Disclaimer

cran-comments.Rmd

@@ -7,8 +7,13 @@ output: md_document
 
 # cran-comments for RAQSAPI
 ## RAQSAPI 2.0.5
+  - fixed an issue where the duration parameter was being ignored in
+    aqs_sampledata_by_* functions.
+  - add note to aqs_sampledurations function about not returning calculated
+    durations
   *RAQSAPI 2.0.4 was not published on CRAN.
-  - The rate limit has been changed from a constant 5 second wait time to a maximum of 10 requests per minute.
+  - The rate limit has been changed from a constant 5 second wait time to a
+    maximum of 10 requests per minute.
   - RAQSAPI will retry certain requests if they fail for a maximum of 5 times
     after a 10 second wait time.
   - Moved to the httr2 backend, removed desc from suggests and

cran-comments.md

@@ -7,8 +7,13 @@ output: md_document
 
 # cran-comments for RAQSAPI
 ## RAQSAPI 2.0.5
+  - fixed an issue where the duration parameter was being ignored in
+    aqs_sampledata_by_* functions.
+  - add note to aqs_sampledurations function about not returning calculated
+    durations
   *RAQSAPI 2.0.4 was not published on CRAN.
-  - The rate limit has been changed from a constant 5 second wait time to a maximum of 10 requests per minute.
+  - The rate limit has been changed from a constant 5 second wait time to a
+    maximum of 10 requests per minute.
   - RAQSAPI will retry certain requests if they fail for a maximum of 5 times
     after a 10 second wait time.
   - Moved to the httr2 backend, removed desc from suggests and