Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support directly linking PlanQK Algorithms in QC-Atlas #243

Closed
mhinkie opened this issue Oct 24, 2023 · 2 comments · Fixed by #245
Closed

Support directly linking PlanQK Algorithms in QC-Atlas #243

mhinkie opened this issue Oct 24, 2023 · 2 comments · Fixed by #245
Assignees

Comments

@mhinkie
Copy link
Contributor

mhinkie commented Oct 24, 2023

When viewing Algorithms from PlanQK in the QC-Atlas UI, they are assigned an URL such as:
http://127.0.0.1/#/algorithms/9d445a80-6707-4a42-9689-4119c47b7120

Although these URLs are visible in the address bar when viewing the algorithm. They can not be opened directly (i.e., by a Link from another Website). To enable linking patterns to algorithms from PlanQK when viewed in QC-Atlas, this direct navigation needs to be supported.

Current situation
Directly opening links as above produces a blank page and the error notification "Error! Algorithm could not be retrieved".
This is because:

  1. The logged-in user is not remembered across Tabs/Windows.
  2. Even if the login-status is kept, it results in a new login, which reloads the page.
  3. When an algorithm is directly linked, QC-Atlas assumes it comes from its own API and does not check PlanQK for this algorithm.

Tasks

  1. Extend keycloak initialization to enable single sign-on and loading user profiles at startup (src/app/util/keycloak-init.ts
  2. Fix page-reload logic in src/app/components/navigation/navigation.component.ts
  3. Change algorithm-view init logic to also check PlanQK if applicable. (src/app/components/algorithms/algorithm-view/algorithm-view.component.ts)
@salmma
Copy link
Contributor

salmma commented Oct 25, 2023

#242 updates Angular to support a newer keycloak version. This PR has to be considered such that the logout from the PlanQK platform works again properly.

@mhinkie
Copy link
Contributor Author

mhinkie commented Nov 6, 2023

Fixed in PR #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants