Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Implementation, Algorithm, and their Dtos abstract #199

Open
2 tasks
salmma opened this issue Aug 18, 2021 · 0 comments · May be fixed by #202
Open
2 tasks

Make Implementation, Algorithm, and their Dtos abstract #199

salmma opened this issue Aug 18, 2021 · 0 comments · May be fixed by #202
Assignees
Labels
help wanted Extra attention is needed invalid This doesn't seem right WIP

Comments

@salmma
Copy link
Contributor

salmma commented Aug 18, 2021

Implementation, ImplementationDto, Algorithm, AlgorithmDto should be abstract.

Maybe this link helps:
https://thorben-janssen.com/complete-guide-inheritance-strategies-jpa-hibernate/

  • make mentioned classes abstract
  • check if sample data is still compatible and update if required
@salmma salmma added the invalid This doesn't seem right label Aug 18, 2021
@salmma salmma linked a pull request Dec 14, 2021 that will close this issue
@salmma salmma added help wanted Extra attention is needed WIP labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed invalid This doesn't seem right WIP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants