FR: Add option to add filters to NetBox requests

[bb-Ricardo]

Collection all the information in our current NetBox environment takes too long and runs into a timeout.

As Icinga might need different attributes from different devices I would propose to add a filter option to this module.

Appending a ?role=Server (as an example) to the request URL would be great. This limits the amount of returned data and we can change the imported data based on the device type.

A text field should be sufficient. The content should be added to the URL upon request.

Just putting this here as a reminder. Currently on Holidays but will try to give it a shot myself once I'm back. From what I've seen it should not be too difficult to implement.

[joni1993]

Try if this works for you 😃

[luto]

@joni1993 Having one filter field per object type (i.e. one for devices and one for VMs) would be nice. What do you think?

[joni1993]

Hm, i don't know - i think multiple filter fields are a bit confusing. Normally you want to apply the filter to all objects - if you need two filters i think cloning the import source may be cleaner (one for the devices, one for the vms).

We could also convert the two yes/no boxes to one select box like => Import: [Devices and VMs, only Devices, only VMs]

[bb-Ricardo]

Cloning the import source is exactly what we currently do. But this looks promising.

[bb-Ricardo]

tried it out with virtual machines but getting this response now.

[joni1993]

That's interesting, this line wasn even touched - I will try again with VMs only, fetching both worked for me today.

[joni1993]

Could it be that your filter is too restrictive and the result is empty? I can see why the listColumns should fail if data is returned - anyway this shouldn't happen of course.

[bb-Ricardo]

Could it be that your filter is too restrictive and the result is empty? I can see why the listColumns should fail if data is returned - anyway this shouldn't happen of course.

This might be the case. Will test again:

[joni1993]

Couldn't reproduce it even with a filter that returns zero elements.

[bb-Ricardo]

Thank you for taking the time to test this.

Will have a look to see what the response contains.