fix: move Dash-specific GetMNByService() check to the end of the while loop

Allows non-specific conditions to trigger first for better compatibility

Author: UdjinM6

src/net.cpp

@@ -3507,9 +3507,6 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect, CDe
                 std::tie(addr, addr_last_try) = addrman.Select(false, preferred_net);
             }
 
-            auto dmn = mnList.GetMNByService(addr);
-            bool isMasternode = dmn != nullptr;
-
             // Require outbound IPv4/IPv6 connections, other than feelers, to be to distinct network groups
             if (!fFeeler && outbound_ipv46_peer_netgroups.count(m_netgroupman.GetGroup(addr))) {
                 continue;
@@ -3520,10 +3517,6 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect, CDe
                 break;
             }
 
-            // don't try to connect to masternodes that we already have a connection to (most likely inbound)
-            if (isMasternode && setConnectedMasternodes.count(dmn->proTxHash))
-                continue;
-
             // don't connect to ourselves
             if (addr.GetPort() == GetListenPort() && IsLocal(addr)) {
                 break;
@@ -3566,6 +3559,11 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect, CDe
                 continue;
             }
 
+            // don't try to connect to masternodes that we already have a connection to (most likely inbound)
+            if (auto dmn = mnList.GetMNByService(addr); dmn && setConnectedMasternodes.count(dmn->proTxHash)) {
+                continue;
+            }
+
             addrConnect = addr;
             break;
         }