Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use dist-packages #222

Closed
ubitux opened this issue Feb 11, 2017 · 4 comments · Fixed by #804 or Ultimaker/Cura#12708
Closed

Do not use dist-packages #222

ubitux opened this issue Feb 11, 2017 · 4 comments · Fixed by #804 or Ultimaker/Cura#12708
Labels
Type: Bug The code does not produce the intended behavior.

Comments

@ubitux
Copy link

ubitux commented Feb 11, 2017

Python's dist-packages directory is debian specific and does not work on any other Linux distribution. The correct directory is site-packages.

Also, the correct directory for site-packages is not python3 but python${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.

Unless these changes are made, no python import can work.

This issue is present in all other repositories.

@Ghostkeeper
Copy link
Collaborator

Ghostkeeper commented Feb 13, 2017

The issue pertains to this line of code:

install(DIRECTORY UM DESTINATION lib/python${PYTHON_VERSION_MAJOR}/dist-packages)

However, we know that it also works on Arch. In fact, the guy who wrote that line of code works on Arch (though he obviously works from source so things may be different until he tests the actual build). In the commit he mentions that it is meant to improve something for Debian though. @awhiemstra, do you know why dist-packages was used?

@ubitux
Copy link
Author

ubitux commented Feb 13, 2017

It doesn't work on Arch, the PKGBUILD files patch the CMakeLists.txt with a sed to correct this. This only works on Debian-like systems.

@awhiemstra
Copy link
Contributor

No indeed it does not, I just never really bothered with it since I use a custom pythonpath anyway when doing development.

Note that we already fixed this for Arcus: https://github.com/Ultimaker/libArcus/blob/master/CMakeLists.txt , we should do something similar here.

@Ghostkeeper Ghostkeeper added the Type: Bug The code does not produce the intended behavior. label Feb 13, 2017
@Ghostkeeper
Copy link
Collaborator

Our product owner just closed this for being inactive for 3 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The code does not produce the intended behavior.
Projects
None yet
3 participants