Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to find the number of vertices #7

Closed
wants to merge 0 commits into from
Closed

Fix to find the number of vertices #7

wants to merge 0 commits into from

Conversation

harinandana02
Copy link
Contributor

No description provided.

Copy link
Member

@filchristou filchristou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. It looks good. Could you just delete the dependencies and the empty lines added ?

Project.toml Outdated
Revise = "295af30f-e4ad-537b-8983-00126c2a3abe"
Run = "e7132d5a-96e2-11e9-15da-db8a129aaaf8"
TestSetExtensions = "98d24dd4-01ad-11ea-1b02-c9a08f80db04"
WrappedMultiGraphs = "2815cbbd-0d7d-431b-a8da-1940906b5714"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these dependencies please? They are not needed in the package.

test/runtests.jl Outdated
@@ -4,5 +4,5 @@ using Test, TestSetExtensions
using WrappedMultiGraphs

@testset "AttributeGraphs.jl" begin
@includetests ["constructors","graphs", "attributes"]
@includetests ["constructors","graphs", "attributes", "opinionated"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the spacing a bit

Suggested change
@includetests ["constructors","graphs", "attributes", "opinionated"]
@includetests ["constructors", "graphs", "attributes", "opinionated"]

@filchristou
Copy link
Member

Also, can you delete the opinionated.jl test file and add the test case in the constructors.jl ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants